Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Extract hardcoded fusion path #15

Closed
wants to merge 1 commit into from

Conversation

dfeyer
Copy link

@dfeyer dfeyer commented Mar 21, 2019

The hardcoded values are extracted to Settings.yaml. This change allow the usage of custom Fusion prototype in the rendering.

Fixes #9

@dfeyer dfeyer requested a review from bwaidelich March 21, 2019 22:11
@bwaidelich
Copy link
Member

@dfeyer Nice one, thanks a lot for this. Would you be up for adding a short paragraph to https://github.com/neos/form-fusionrenderer/blob/master/README.md explaining the new feature?

Neos.Fusion:Private/Fusion: true
Neos.Form.FusionRenderer:Private/Fusion/Core: true
Neos.Form.FusionRenderer:Private/Fusion/ContainerElements: true
Neos.Form.FusionRenderer:Private/Fusion/Elements: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just wondering: Do we really need such a fine granular configuration?
If we used a setting similar to Neos.Neos.fusion.autoInclude (= package based) this would get quite a bit simpler. What do you think?

Copy link
Author

@dfeyer dfeyer Mar 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most form are uncached, so I think it's nice is we can load just the required fusion. For two recent projet, I just need one or two new fusion object, but I load the full package, I load tons of fusion prototype that are not need for form rendering. Without a granular configuration I need to create a separate package ... that can work too.

get quite a bit simpler

Neos:
  Form:
    FusionRenderer:
      fusionPathPatterns:
        My.Package:Private/Form: true

It's simple ;)

@bwaidelich So the question is more did we want a consistent configuration ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true. I'm fine with both

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about this one again.. Maybe we could use the glob syntax that we use for includes from Fusion, too!?

@daniellienert
Copy link
Member

Since Neos 5.0 the FusionView::setFusionPathPatternsexpects a root.fusion in its path versus globbing the complete path. So this solution would not work as it is now. I suggest to extend the fusion paths with #21

Copy link
Member

@daniellienert daniellienert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will not work with Neos 5.x

@daniellienert
Copy link
Member

Hey @dfeyer, thanks for the PR. Due to changed in Neos 5, #21 was merged as a replacement for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Foreign Fusion Prototypes and Eel Helpers to be used
3 participants