Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Drop code for PHP < 8 #3412

Merged
merged 1 commit into from
Nov 5, 2024
Merged

TASK: Drop code for PHP < 8 #3412

merged 1 commit into from
Nov 5, 2024

Conversation

kdambekalns
Copy link
Member

This drops code that was only executed on PHP < 8.0, and thus will never ever be run again.
Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@kdambekalns kdambekalns self-assigned this Nov 5, 2024
@kdambekalns
Copy link
Member Author

What's with the test failure? 🙄

@dlubitz
Copy link
Contributor

dlubitz commented Nov 5, 2024

See: #3409

Was merged right now, you just need to rebase.

@kdambekalns kdambekalns closed this Nov 5, 2024
@kdambekalns kdambekalns reopened this Nov 5, 2024
@kitsunet kitsunet merged commit 87c6087 into neos:8.3 Nov 5, 2024
12 of 17 checks passed
@kdambekalns kdambekalns deleted the task/drop-php-7-code branch November 5, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlubitz dlubitz dlubitz approved these changes

@kitsunet kitsunet kitsunet approved these changes

Assignees

@kdambekalns kdambekalns

Labels
8.3 Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kdambekalns @dlubitz @kitsunet