BUGFIX: No usage of dynamic properties

[kitsunet]

This patch resolves deprecation notices on PHP 8.2:

Dynamic properties in proxy classes

There are some properties that are dynamically declared in proxy classes:

• Flow_Injected_Properties
• Flow_Object_PropertiesToSerialize
• Flow_Persistence_RelatedEntities: this is mostly used inside of the ObjectSerializationTrait, so I thought it might make more sense to declare it there instead of adding a property using the ProxyClassBuilder

Resolves #2946

parent inside of closures

There are some methods that will be checked against is_callable with parent:::

• parent::Flow_Aop_Proxy_buildMethodsAndAdvicesArray
• parent::__wakeup

Review instructions

• Set up a flow distribution on PHP 8.2
• Run tests and make sure no deprecation warnings are thrown

Checklist

• Code follows the PSR-2 coding style
• Tests have been created, run and adjusted as needed
• The PR is created against the lowest maintained branch
• Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
• Reviewer - The first section explains the change briefly for change-logs
• Reviewer - Breaking Changes are marked wit !!! and have upgrade-instructions

[kitsunet]

See also #2950

[fcool]

Shouldn't that target 7.3, too?

[kdambekalns]

Looks good by reading.

[kdambekalns]

Shouldn't that target 7.3, too?

Well, Flow 7.3 supports PHP 8.0, that's true. But what this addresses is more for PHP 8.2, see https://www.php.net/releases/8.2/en.php#deprecate_dynamic_properties – so I guess it's fine to target Flow 8.0…

[robertlemke]

This looks fine and I tested the code contained in the traits at least. However, I can imagine that there will be some merge conflicts when upmerging to 9.0 due to the little clean ups you added.

[kitsunet]

@robertlemke would you prefer I remove any cleanups before merging?

[robertlemke]

@robertlemke would you prefer I remove any cleanups before merging?

I think they are fine, but whoever does the upmerge needs to know a little what he/she is doing.

[robertlemke]

I hope I knew what I was doing, but for the record: I just did the upmerges.