Ndev 3380 compasability for iterative trx #456
Conversation
…unction scope fix test_step_from_instruction_for_counter: use holder account with function scope
fix iterative transaction tests: reduce iteration lenght
fix: new holder account for all interoperability tests
…deploy contracy and solana call add composability test cases: iterative actions + solana call/calls, deploy contracy and solana call
fix deploy contract and solana call test
| event_logs = call_solana_caller.events.LogBytes().process_receipt(resp) | ||
| assert int.from_bytes(event_logs[0].args.value, byteorder="little") == next(get_counter_value) | ||
|
|
||
| def test_iterative_actions_after_solana_call_exceed_accounts_limit(self, counter_resource_address, call_solana_caller, get_counter_value): |
There was a problem hiding this comment.
this test can be deleted
iterative actions after solana call can't be called at all
There was a problem hiding this comment.
It is working now and idk why, I asked the core team about this and wait for their response
| function deployStorageAndCallSolana(string memory message, uint64 lamports, bytes calldata instruction) public { | ||
| Storage storageContract = new Storage(); | ||
| execute(lamports, instruction); | ||
| emit LogStr(message); |
There was a problem hiding this comment.
it is better to return storageContract address and try to call it in the test or at least to check that address exist and contains some code
There was a problem hiding this comment.
I added call contract function and I return contract address
| event_logs = call_solana_caller.events.LogBytes().process_receipt(resp) | ||
| assert int.from_bytes(event_logs[0].args.value, byteorder="little") == next(get_counter_value) | ||
|
|
||
| def test_multiple_solana_calls_and_iterative_actions_instructions_limit(self, counter_resource_address, call_solana_caller, get_counter_value): |
There was a problem hiding this comment.
I think we don't need this test
the same as with 1 call
There was a problem hiding this comment.
There was an issue, where the instruction limit test had failed for an iterative transaction only. I kept this test to check the issue is fixed, and I still want to keep it. What do you think?
| resp = self.web3_client.send_transaction(sender, instruction_tx) | ||
| assert resp["status"] == 1 | ||
| event_logs = call_solana_caller.events.LogBytes().process_receipt(resp) | ||
| assert int.from_bytes(event_logs[0].args.value, byteorder="little") == next(get_counter_value) |
There was a problem hiding this comment.
what the value of next(get_counter_value) here? I think it should be = solana_calls
There was a problem hiding this comment.
fixed: I check a number of logged solana calls now
rm tests with no iterative txs check
check holder account state after tx execution
rename test test_solana_call_before_iterative_actions
…ns_id add case: eip 1559 iterative tx check with program_id = transfer_tokens_id
add case: failed solana call
add case: iterative tx with solana call in sol network
rm dbg info
add case: iterative tx with send tokens
add case of solana call with 2 programs, minor refactoring
fix review
…tiple_solana_calls_instructions_limit, test_transfer_with_pda_signature_iterative_tx_eip_1559
No description provided.