-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'write version' to EmulateRequestModel #212
Add 'write version' to EmulateRequestModel #212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, write_version should be passed as a parameter to the functions, not to the builder of the client.
What do you think @stanislav-tkach @andreisilviudragnea ?
I though that the write version value is similar to a slot one that is already passed to the client constructor. I'm OK with both approaches, but I have a feeling that passing it as a parameter to function will be more verbose. |
0edbf62
to
3336246
Compare
@Deniskore The In the case of Both |
51e401b
to
024e271
Compare
024e271
to
8adfb4d
Compare
* Add 'write version' to EmulateRequestModel
The write version is needed to correctly trace transactions because we need the exact state of the accounts.
Related to https://github.com/neonlabsorg/tracer-api/pull/67.