NDEV-2184: Report error when requested too early slot #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanislav-tkach
approved these changes
Sep 15, 2023
afalaleev
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Remove #[allow(dead_code)] * NDEV-2184: Report error when requested too early slot
afalaleev
pushed a commit
that referenced
this pull request
Oct 18, 2023
* Remove #[allow(dead_code)] * NDEV-2184: Report error when requested too early slot
afalaleev
pushed a commit
that referenced
this pull request
Oct 18, 2023
* Remove #[allow(dead_code)] * NDEV-2184: Report error when requested too early slot
afalaleev
pushed a commit
that referenced
this pull request
Oct 27, 2023
* Remove #[allow(dead_code)] * NDEV-2184: Report error when requested too early slot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added error handling for providing a slot less the earliest slot for the following
/apiendpoints:/emulate/get-ether-account-data/get-storage-at/trace/trace-next-blockThe error for GET request to
http://localhost:8080/api/get-ether-account-data?ether=0xbf7043bf6f60ada5b71b0ef7a0264baf93edd1cc&slot=240249818looks like this:400 Bad Request