NDEV-2043: Improve performance of neon-api crate #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreisilviudragnea
force-pushed
the
NDEV-2043
branch
2 times, most recently
from
0989ceb to
42098a4
Compare
andreisilviudragnea
changed the title
andreisilviudragnea
changed the title
andreisilviudragnea
force-pushed
the
NDEV-2043
branch
6 times, most recently
from
1d83a33 to
84c22a0
Compare
|
The problem about using actix-web is that we cannot use |
|
@Denommus Yes, you are right, but we are not using it anywhere anymore. This was the purpose of this PR, converting blocking contexts where async functions need to be executed into async contexts themselves. |
anton-lisanin
requested changes
Aug 22, 2023
dk-neon
suggested changes
Aug 24, 2023
andreisilviudragnea
force-pushed
the
NDEV-2043
branch
7 times, most recently
from
f9c157c to
593b226
Compare
andreisilviudragnea
force-pushed
the
NDEV-2043
branch
from
254301c to
f241842
Compare
anton-lisanin
requested changes
Sep 22, 2023
andreisilviudragnea
force-pushed
the
NDEV-2043
branch
from
f241842 to
1515a06
Compare
andreisilviudragnea
force-pushed
the
NDEV-2043
branch
from
93c9e2d to
cbcdd4a
Compare
andreisilviudragnea
added
extendedFullTestSuite
and removed
fullTestSuite
|
In I don't like that we have diffirent tools to do the same. |
andreisilviudragnea
force-pushed
the
NDEV-2043
branch
from
822ac51 to
b04820f
Compare
andreisilviudragnea
force-pushed
the
NDEV-2043
branch
from
88a25cb to
5303cf6
Compare
|
@anton-lisanin I replaced all usages of |
|
anton-lisanin
approved these changes
Sep 26, 2023
afalaleev
pushed a commit
that referenced
this pull request
Oct 11, 2023
The main purpose of this PR is to remove usages of [`block_in_place`](https://docs.rs/tokio/latest/tokio/task/fn.block_in_place.html) and to re-use the same code in both an async (`neon-api`) and non-async (`evm-loader`) context. - Replaced `#[cfg(feature = "tracing")]` with `#[cfg(target_os = "solana")]` and extended its usage to: - code from `evm-loader` crate used only as a library (`#[cfg(not(target_os = "solana")]`); - code from `evm-loader` crate used only as part of a Solana program (`#[cfg(target_os = "solana")]`). - Replaced [`axum`](https://github.com/tokio-rs/axum) with [`actix-web`](https://github.com/actix/actix-web), because most of the `evm-loader` crate is based on non-`Send` types and [`actix-web`](https://github.com/actix/actix-web) is a web framework which does not require `Future`s to be `Send`. Inspired from #107. - Used [`maybe_async`](https://github.com/fMeow/maybe-async-rs) crate to re-write common parts of `evm-loader` crate used both as an async library and as a non-async Solana program. This also removed all usages of [`block_in_place`](https://docs.rs/tokio/latest/tokio/task/fn.block_in_place.html). - Simplified all types related to multi-threading in the context of non-`Send` `Future`s: less `Arc`s, less `RwLock`s.
afalaleev
pushed a commit
that referenced
this pull request
Oct 18, 2023
The main purpose of this PR is to remove usages of [`block_in_place`](https://docs.rs/tokio/latest/tokio/task/fn.block_in_place.html) and to re-use the same code in both an async (`neon-api`) and non-async (`evm-loader`) context. - Replaced `#[cfg(feature = "tracing")]` with `#[cfg(target_os = "solana")]` and extended its usage to: - code from `evm-loader` crate used only as a library (`#[cfg(not(target_os = "solana")]`); - code from `evm-loader` crate used only as part of a Solana program (`#[cfg(target_os = "solana")]`). - Replaced [`axum`](https://github.com/tokio-rs/axum) with [`actix-web`](https://github.com/actix/actix-web), because most of the `evm-loader` crate is based on non-`Send` types and [`actix-web`](https://github.com/actix/actix-web) is a web framework which does not require `Future`s to be `Send`. Inspired from #107. - Used [`maybe_async`](https://github.com/fMeow/maybe-async-rs) crate to re-write common parts of `evm-loader` crate used both as an async library and as a non-async Solana program. This also removed all usages of [`block_in_place`](https://docs.rs/tokio/latest/tokio/task/fn.block_in_place.html). - Simplified all types related to multi-threading in the context of non-`Send` `Future`s: less `Arc`s, less `RwLock`s.
afalaleev
pushed a commit
that referenced
this pull request
Oct 18, 2023
The main purpose of this PR is to remove usages of [`block_in_place`](https://docs.rs/tokio/latest/tokio/task/fn.block_in_place.html) and to re-use the same code in both an async (`neon-api`) and non-async (`evm-loader`) context. - Replaced `#[cfg(feature = "tracing")]` with `#[cfg(target_os = "solana")]` and extended its usage to: - code from `evm-loader` crate used only as a library (`#[cfg(not(target_os = "solana")]`); - code from `evm-loader` crate used only as part of a Solana program (`#[cfg(target_os = "solana")]`). - Replaced [`axum`](https://github.com/tokio-rs/axum) with [`actix-web`](https://github.com/actix/actix-web), because most of the `evm-loader` crate is based on non-`Send` types and [`actix-web`](https://github.com/actix/actix-web) is a web framework which does not require `Future`s to be `Send`. Inspired from #107. - Used [`maybe_async`](https://github.com/fMeow/maybe-async-rs) crate to re-write common parts of `evm-loader` crate used both as an async library and as a non-async Solana program. This also removed all usages of [`block_in_place`](https://docs.rs/tokio/latest/tokio/task/fn.block_in_place.html). - Simplified all types related to multi-threading in the context of non-`Send` `Future`s: less `Arc`s, less `RwLock`s.
Merged
afalaleev
pushed a commit
that referenced
this pull request
Oct 27, 2023
The main purpose of this PR is to remove usages of [`block_in_place`](https://docs.rs/tokio/latest/tokio/task/fn.block_in_place.html) and to re-use the same code in both an async (`neon-api`) and non-async (`evm-loader`) context. - Replaced `#[cfg(feature = "tracing")]` with `#[cfg(target_os = "solana")]` and extended its usage to: - code from `evm-loader` crate used only as a library (`#[cfg(not(target_os = "solana")]`); - code from `evm-loader` crate used only as part of a Solana program (`#[cfg(target_os = "solana")]`). - Replaced [`axum`](https://github.com/tokio-rs/axum) with [`actix-web`](https://github.com/actix/actix-web), because most of the `evm-loader` crate is based on non-`Send` types and [`actix-web`](https://github.com/actix/actix-web) is a web framework which does not require `Future`s to be `Send`. Inspired from #107. - Used [`maybe_async`](https://github.com/fMeow/maybe-async-rs) crate to re-write common parts of `evm-loader` crate used both as an async library and as a non-async Solana program. This also removed all usages of [`block_in_place`](https://docs.rs/tokio/latest/tokio/task/fn.block_in_place.html). - Simplified all types related to multi-threading in the context of non-`Send` `Future`s: less `Arc`s, less `RwLock`s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to remove usages of
block_in_placeand to re-use the same code in both an async (neon-api) and non-async (evm-loader) context.#[cfg(feature = "tracing")]with#[cfg(target_os = "solana")]and extended its usage to:evm-loadercrate used only as a library (#[cfg(not(target_os = "solana")]);evm-loadercrate used only as part of a Solana program (#[cfg(target_os = "solana")]).axumwithactix-web, because most of theevm-loadercrate is based on non-Sendtypes andactix-webis a web framework which does not requireFutures to beSend. Inspired from Convert (most) of neon-lib to async #107.maybe_asynccrate to re-write common parts ofevm-loadercrate used both as an async library and as a non-async Solana program. This also removed all usages ofblock_in_place.SendFutures: lessArcs, lessRwLocks.