Tba 212 fix inconsistencies in erc20 for spl documentation #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated specification of constructors for ERC20-For-Spl and ERC20-For-Spl-Mintable
* Fixed dead link in Metaplex metadata
There was a problem hiding this comment.
@OlehSyzonov pls check my comments. I believe we should add warning box for erc20forsplmintable that it's highly desirable to not place decimals greater than 9. Not applying to this rule will lead to issues with math operations inside the smart contract.
docs/developing/deploy_facilities/interacting_with_spl_tokens.md
Outdated
Show resolved
Hide resolved
* Improved crrectness of the text
+ Added a warning to not define `decimals` greater than 9
*Grammar improvements
+ Added ## Deploying chapter
@mnedelchev-vn please, see if it is good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ERC20-For-Spl-Mintable