Address version seed and extend account data size #196 #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otselnik
requested review from
vakond,
anton-lisanin,
sinev-valentine,
s-medvedev and
vasiliy-zaznobin
otselnik
changed the title
s-medvedev
reviewed
Aug 31, 2021
| @@ -6,6 +6,11 @@ use solana_program::{ | |||
| pubkey::Pubkey, | |||
| }; | |||
|
|
|||
| /// Ethereum account version | |||
| pub const ACCOUNT_VERSION: u32 = 1_u32; | |||
There was a problem hiding this comment.
I suggest renaming to ACCOUNT_SEED_VERSION and change the type to u8. In the feature, we can increase it to u16 without any problems.
s-medvedev
approved these changes
Aug 31, 2021
afalaleev
pushed a commit
that referenced
this pull request
Oct 27, 2023
* added pr_url as param * fix param name * Update pipeline.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.