166 faucet (outdated) #179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-medvedev
reviewed
Sep 23, 2021
evm_loader/faucet/Cargo.toml
Outdated
| toml = "0.5" | ||
| tracing = "0.1" | ||
| tracing-subscriber = "0.2" | ||
| web3 = { path = "web3" } |
There was a problem hiding this comment.
Why we can't use web3 package from the rust repository?
There was a problem hiding this comment.
It was because of gasPrice. I started with the public version of web3, of course, but had to modify it to support non-standard result of the proxy's gasPrice at that time. Probably we should try to return to the public version of web3 crate.
arkadyone
pushed a commit
to arkadyone/neon-evm
that referenced
this pull request
Nov 25, 2022
* fix search * added gtag and configured search for re-index
afalaleev
pushed a commit
that referenced
this pull request
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed as outdated