Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: use fewer pageservers in test_sharding_split_smoke #9804

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

jcsp
Copy link
Collaborator

@jcsp jcsp commented Nov 19, 2024

Problem

This test uses a gratuitous number of pageservers (16). This works fine when there are plenty of system resources, but causes issues on test runners that have limited resources and run many tests concurrently.

Related: #9802

Summary of changes

  • Split from 2 shards to 4, instead of 4 to 8
  • Don't give every shard a separate pageserver, let two locations share each pageserver.

Net result is 4 pageservers instead of 16

@jcsp jcsp added a/test Area: related to testing a/tech_debt Area: related to tech debt labels Nov 19, 2024
Copy link

github-actions bot commented Nov 19, 2024

5526 tests run: 5300 passed, 0 failed, 226 skipped (full report)


Flaky tests (1)

Postgres 15

Code coverage* (full report)

  • functions: 31.4% (7941 of 25300 functions)
  • lines: 49.3% (63013 of 127730 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
0b6c293 at 2024-11-20T13:54:19.434Z :recycle:

@jcsp jcsp changed the title Jcsp/issue 9802 fewer pageservers tests: use fewer pageservers in test_sharding_split_smoke Nov 20, 2024
@jcsp jcsp requested a review from arssher November 20, 2024 09:45
@jcsp jcsp marked this pull request as ready for review November 20, 2024 09:45
@jcsp jcsp enabled auto-merge (squash) November 20, 2024 11:07
@jcsp jcsp disabled auto-merge November 20, 2024 14:57
@jcsp jcsp added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit 593e350 Nov 20, 2024
78 checks passed
@jcsp jcsp deleted the jcsp/issue-9802-fewer-pageservers branch November 20, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt a/test Area: related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants