-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use reusable workflow for MacOs build #9392
base: main
Are you sure you want to change the base?
Conversation
- name: Check for Postgres changes | ||
uses: dorny/paths-filter@1441771bbfdd59dcd748680ee64ebd8faab1a242 #v3 | ||
id: postgres_changes | ||
with: | ||
token: ${{ github.token }} | ||
filters: | | ||
postgres-v14: ['vendor/postgres-v14/**', 'Makefile', '.github/workflows/build-macos.yml', 'pgxn/**'] | ||
postgres-v15: ['vendor/postgres-v15/**', 'Makefile', '.github/workflows/build-macos.yml', 'pgxn/**'] | ||
postgres-v16: ['vendor/postgres-v16/**', 'Makefile', '.github/workflows/build-macos.yml', 'pgxn/**'] | ||
postgres-v17: ['vendor/postgres-v17/**', 'Makefile', '.github/workflows/build-macos.yml', 'pgxn/**'] | ||
base: ${{ github.event_name != 'pull_request' && (github.event.merge_group.base_ref || github.ref_name) || '' }} | ||
ref: ${{ github.event_name != 'pull_request' && (github.event.merge_group.head_ref || github.ref) || ''}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about having this part in the main build_and_test
workflow and trigger build-macos
only if there're related changes.
We might want to consider using https://github.com/tj-actions/changed-files (instead of dorny/paths-filter
), I found its API nicer
postgres_changes: ${{ steps.postgres_changes.outputs.changes }} | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@6ccd57f4c5d15bdc2fef309bd9fb6cc9db2ef1c6 # v4.1.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're ok to use the latest tag (like @v4
) for "official" actions from actions
org
Problem
Summary of changes
Checklist before requesting a review
Checklist before merging