Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure blobs: Simplify error conversion by addition of to_download_error #5575

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

arpad-m
Copy link
Member

@arpad-m arpad-m commented Oct 16, 2023

There is a bunch of duplication and manual Result handling that can be simplified by moving the error conversion into a shared function, using map_err, and the question mark operator.

@arpad-m arpad-m requested a review from a team as a code owner October 16, 2023 21:19
@arpad-m arpad-m requested review from problame and removed request for a team October 16, 2023 21:19
@github-actions
Copy link

2292 tests run: 2176 passed, 0 failed, 116 skipped (full report)


Code coverage (full report)

  • functions: 52.9% (8263 of 15613 functions)
  • lines: 80.6% (48192 of 59786 lines)

The comment gets automatically updated with the latest test results
fdf30a8 at 2023-10-16T21:53:05.128Z :recycle:

@arpad-m arpad-m merged commit b1d6af5 into main Oct 19, 2023
@arpad-m arpad-m deleted the arpad/azure_error_conversion branch October 19, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants