for #3919: undo take_mut usage introduced in 11c18b0 #4156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partially reverts commit 11c18b0 for the take_mut parts.
koivunej
requested review from
lubennikovaav,
shanyp and
problame
and removed request for
a team,
lubennikovaav and
shanyp
Test results for ad70535:debug build: 233 tests run: 223 passed, 0 failed, 10 skipped (full report)release build: 233 tests run: 223 passed, 0 failed, 10 skipped (full report) |
This was referenced May 4, 2023
|
Good changes, bad title. The essence of 11c18b0 was to move the IndexPart construction into the I'll rename the PR to what it does, |
problame
changed the title
|
Updated the PR description to the commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit
11c18b0introducedtake_mut, but, it's actually not necessary here.take_mutis dangerous because it aborts if the closure handed to it panics.We have asserts in there, let's not risk an abort.
Alternative to #4153.