vm-runner: arm support #1119
vm-runner: arm support #1119
Conversation
No changes to the coverage.
HTML Report |
mikhail-sakhnov
force-pushed
the
misha/runner-arm-support
branch
from
e5a9046
to
111e19c
Compare
| } | ||
| } | ||
|
|
||
| func getMachineType(architecture string) string { |
There was a problem hiding this comment.
It'd be good to have a comment explaining the situation here -- why these particular machine types?
There was a problem hiding this comment.
tbh there are no particular reason. for q35 it is probably historical reason and virt is the most generic arm platform which we use in runners already.
There was a problem hiding this comment.
perhaps @cicdteam can add some context on why q35?
There was a problem hiding this comment.
Sorry, I just saw this discussion.
In the x86_64 architecture, QEMU has two groups of emulated machines - pc-q35 and pc-i440fx (yes, there are a couple of others, like microvm or none, but this is not our case). The q35 series is more recent, so it was chosen. In fact, there are no other options for x86_64.
FYI: -machine q35 is alias of -machine pc-q35-9.0 (in QEMU v9.0.1),by other words - most recent hardware.
mikhail-sakhnov
force-pushed
the
misha/runner-arm-support
branch
from
111e19c
to
853186d
Compare
mikhail-sakhnov
force-pushed
the
misha/runner-arm-support
branch
2 times, most recently
from
ecc2853
to
8a7a20c
Compare
mikhail-sakhnov
force-pushed
the
misha/builder-arm-support
branch
from
ed64800
to
629281d
Compare
mikhail-sakhnov
force-pushed
the
misha/runner-arm-support
branch
from
8a7a20c
to
3d7f393
Compare
Signed-off-by: Misha Sakhnov <[email protected]>
mikhail-sakhnov
force-pushed
the
misha/runner-arm-support
branch
from
3d7f393
to
59ccc89
Compare
mikhail-sakhnov
force-pushed
the
misha/builder-arm-support
branch
from
629281d
to
6fb99e4
Compare
Signed-off-by: Mikhail Sakhnov <[email protected]>
Modify qemu arguments to run VM on arm machine