lint: bump golangci-lint to v1.59.1 and fix new warnings

Signed-off-by: Oleg Vasilev <[email protected]>
neondatabase · Jul 9, 2024 · 3b19cc5 · 3b19cc5
1 parent b5ba2a9
commit 3b19cc5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -23,7 +23,7 @@ jobs:
         with:
           # Required: the version of golangci-lint is required and
           # should be specified with patch version.
-          version: v1.58.1
+          version: v1.59.1
           args: --timeout 5m
           github-token: ${{ secrets.github_token }}
           # caching issues, see: https://github.com/golangci/golangci-lint-action/issues/244#issuecomment-1052190775

diff --git a/neonvm/apis/neonvm/v1/virtualmachine_types.go b/neonvm/apis/neonvm/v1/virtualmachine_types.go
@@ -353,8 +353,10 @@ func (m MilliCPU) MarshalJSON() ([]byte, error) {
 func (m MilliCPU) Format(state fmt.State, verb rune) {
 	switch {
 	case verb == 'v' && state.Flag('#'):
+		//nolint:errcheck // can't do anything about the write error
 		state.Write([]byte(fmt.Sprintf("%v", uint32(m))))
 	default:
+		//nolint:errcheck // can't do anything about the write error
 		state.Write([]byte(fmt.Sprintf("%v", m.AsFloat64())))
 	}
 }

diff --git a/pkg/api/types.go b/pkg/api/types.go
@@ -272,8 +272,10 @@ func (b Bytes) MarshalJSON() ([]byte, error) {
 func (b Bytes) Format(state fmt.State, verb rune) {
 	switch {
 	case verb == 'v' && state.Flag('#'):
+		//nolint:errcheck // can't do anything about the write error
 		state.Write([]byte(fmt.Sprintf("%v", uint64(b))))
 	default:
+		//nolint:errcheck // can't do anything about the write error
 		state.Write([]byte(b.ToResourceQuantity().String()))
 	}
 }