Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(neon): sys feature to give access to Node-API #970

Merged
merged 1 commit into from
Apr 14, 2023
Merged

feat(neon): sys feature to give access to Node-API #970

merged 1 commit into from
Apr 14, 2023

Conversation

kjvalencik
Copy link
Member

@kjvalencik kjvalencik commented Feb 27, 2023 •
edited
Loading

There have been multiple examples where users would like to do something that extends Neon, but requires direct access to Node-API. Sometimes these features to not align with Neon's philosophy.

As an escape hatch, we provide an unsafe sys feature that exposes Node-API and conversions to and from Neon types.

@kjvalencik kjvalencik marked this pull request as ready for review March 17, 2023 16:28
@kjvalencik kjvalencik changed the title feat(neon): Sys feat(neon): sys feature to give access to Node-AP Mar 17, 2023
dherman
dherman approved these changes Mar 24, 2023
View reviewed changes
Copy link
Collaborator

@dherman dherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing. Just a few small suggestions and a couple clarifying questions. I don't think you need a re-review after making any tweaks.

crates/neon/src/context/mod.rs Show resolved Hide resolved
crates/neon/src/handle/mod.rs Show resolved Hide resolved
crates/neon/src/result/mod.rs Show resolved Hide resolved
crates/neon/src/sys/bindings/functions.rs Show resolved Hide resolved
crates/neon/src/sys/mod.rs Outdated Show resolved Hide resolved
crates/neon/src/types_impl/buffer/mod.rs Show resolved Hide resolved
crates/neon/src/types_impl/mod.rs Outdated Show resolved Hide resolved
@kjvalencik kjvalencik changed the title feat(neon): sys feature to give access to Node-AP feat(neon): sys feature to give access to Node-API Apr 10, 2023
@kjvalencik kjvalencik mentioned this pull request Apr 14, 2023
Open
@kjvalencik kjvalencik merged commit 4ff5555 into main Apr 14, 2023
@kjvalencik kjvalencik deleted the kv/sys branch April 14, 2023 16:18
@kjvalencik kjvalencik mentioned this pull request Apr 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dherman dherman dherman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kjvalencik @dherman