-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
neon-build
refactor to make use of dynamic loading
#647
Conversation
…logic * Update to 2018 edition * Re-structure to platform module structure * Remove `cfg-if` * Make `ureq` unconditionally required * Document `neon-build`
765aa60
to
ea6e96b
Compare
48a2e88
to
f21eecd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I just suggest we rename the Builder
API.
crates/neon-build/src/napi/mod.rs
Outdated
output_file: Option<PathBuf>, | ||
} | ||
|
||
impl Builder { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Builder
is a confusing name since it doesn't describe what it does -- and it also could be confusing because this crate is neon_build
but Builder
isn't about running a Neon build.
We talked about Setup::options()
being the way to construct this thing. I think it reads nicely.
…eon_build::Setup::options()`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is a little large, but includes several related commits:
neon-build
. This commit introduces no functional changes. It re-organizesnapi
andneon-sys
building so they are entirely separate.napi
build to make use of dynamic loading. It only needs to output theindex.node
fileneon_build::Builder
for customizing theindex.node
location