Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a default AFTER ordering for the NeoForge dependency #156

Open
wants to merge 1 commit into
base: 1.21-mdg
Choose a base branch
from

Conversation

dhyces
Copy link

@dhyces dhyces commented Sep 29, 2024

Modders will almost always want their own data loaded after NeoForge's data is loaded. Using a default of NONE will seemingly break modder's data when trying to override recipes or other data that NeoForge overrides or implements itself. Using a default order of AFTER in the MDK itself will prevent these issues from cropping up and create a more pleasant experience while working with the mod loader.

@Matyrobbrt
Copy link
Member

I don't necessarily like this change. It will also make people copy paste the dep declaration and have all of their dependencies load AFTER, defeating part of parallel loading as constructors with dependency requirements have to wait for dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants