Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object doesn't support property or method 'assign' #55

Closed
zucker-rdrg opened this issue Sep 7, 2016 · 4 comments · Fixed by #58
Closed

Object doesn't support property or method 'assign' #55

zucker-rdrg opened this issue Sep 7, 2016 · 4 comments · Fixed by #58
Assignees
Labels
Milestone

Comments

@zucker-rdrg
Copy link

Cannot use qrious in IE or Safari <= 8
https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Object/assign#Browser_compatibility

@neocotic neocotic added the bug label Sep 7, 2016
@neocotic neocotic modified the milestones: 3.0.0, 2.0.3 Sep 7, 2016
@neocotic
Copy link
Owner

neocotic commented Sep 7, 2016

Good spot! I was under the impression that Babel replaced such code. I'll take a look at this.

@neocotic
Copy link
Owner

I just wanted to provide an update on this as I've not done so for a while.

It would seem that, in order to get this working with the current system, I'll have to include the babel-runtime transformers inside of QRious. This isn't too tricky to do, however, it comes at a cost. Doing so will no doubt add a big bloat (~20KB) to the minified code base. I'm going to look into ways of minimizing this and possible alternatives such as not using ES6+Babel (another rewrite 😢).

I'm tempted to take a staged approach to this:

  1. Fix bug by including babel-runtime transformers
  2. Try to minimize bloat using whatever means possible

neocotic pushed a commit that referenced this issue Oct 4, 2016
@neocotic neocotic self-assigned this Oct 4, 2016
@neocotic neocotic mentioned this issue Oct 4, 2016
5 tasks
@neocotic
Copy link
Owner

neocotic commented Oct 4, 2016

This issue should be fixed in the just-released version 2.1.0 of QRious.

Please try upgrading and let me know how you get on.

As a result of the fix, babel-runtime has been bundled in our distribution files. Unfortunately, this has added some bloat to the size of our files so I've raised #59 which will attempt to investigate and address this.

@zucker-rdrg
Copy link
Author

Hi,
I've checked this on IE 10 and it works :)

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants