Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inlayHint): only check condition for Neovim #5083

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

kevinhwang91
Copy link
Contributor

Append the last commit

Sorry, I only tested demo without nvim.isVim condition and forgot to debug again after adding nvim.isVim condition.
Mistakenly thinking nvim.isVim is nvim.isNvim.

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.48%. Comparing base (6e1efbf) to head (6fce1f9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5083      +/-   ##
==========================================
- Coverage   98.51%   98.48%   -0.04%     
==========================================
  Files         273      273              
  Lines       26091    26091              
  Branches     5391     5391              
==========================================
- Hits        25704    25696       -8     
- Misses        226      232       +6     
- Partials      161      163       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fannheyward fannheyward merged commit cbf525d into neoclide:master Jul 11, 2024
3 of 4 checks passed
fannheyward added a commit that referenced this pull request Jul 15, 2024
33d0a52 feat(schema): more workspace.ignoredFolders (#5084)
cbf525d fix(inlayHint): only check condition for Neovim (#5083)
6e1efbf fix(inlayHint): correct gravity for virt_text (#5081)
cfa1115 docs(config): add missing docs (#5080)
a00ff12 feat(diagnostic): remove ANSI codes from virtual text (#5077)
16dfda7 chore(packages): bump typescript and ts-eslint (#5074)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants