Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript-3.7.0 breaks 'Import declaration conflicts with local declaration of 'SpawnOptions' #1436

Closed
dezza opened this issue Dec 30, 2019 · 1 comment · Fixed by #1437
Closed
Labels
bug Something isn't working

Comments

@dezza
Copy link
Contributor

dezza commented Dec 30, 2019

I was fiddling with trying to build an example extension when I discovered this compatability break which happened since typescript 3.6.2-3.7.0 change
node_modules/coc.nvim/lib/language-client/index.d.ts:2:14 - error TS2440: Import declaration conflicts with local declaration of 'SpawnOptions'. on running tsc -p tsconfig.json

Source link to offending line:
https://github.com/neoclide/coc.nvim/blob/master/src/language-client/index.ts#L5

Downgrading to 3.6.2 fixes builds with no errors on tsc -p tsconfig.json

Official note on this 3.7.0 change: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html#local-and-imported-type-declarations-now-conflict'

@chemzqm chemzqm added the bug Something isn't working label Dec 30, 2019
@chemzqm
Copy link
Member

chemzqm commented Dec 30, 2019

We need fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants