Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add translantion for kernel_options and kernel_options_post #299

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

skycastlelily
Copy link
Contributor

No description provided.

@dav-pascual dav-pascual self-requested a review October 11, 2024 16:26
@dav-pascual
Copy link
Member

Hi @skycastlelily, changes look good.
Could you please fix the flake8 warnings?

@skycastlelily
Copy link
Contributor Author

skycastlelily commented Oct 18, 2024 via email

@Tiboris
Copy link
Member

Tiboris commented Oct 18, 2024

@skycastlelily Hello, please see https://github.com/neoave/mrack/actions/runs/11395400988/job/31720359590?pr=299 for more small issues in a code. Also i think @dav-pascual would welcome the fixes to be included in first commit.

@skycastlelily
Copy link
Contributor Author

skycastlelily commented Oct 18, 2024 via email

@dav-pascual
Copy link
Member

dav-pascual commented Oct 24, 2024

@skycastlelily
Copy link
Contributor Author

skycastlelily commented Oct 25, 2024 via email

@dav-pascual
Copy link
Member

@skycastlelily Sorry for the late reply. All good, thank you :)

@dav-pascual dav-pascual merged commit 868523c into neoave:main Oct 30, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants