-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add translantion for kernel_options and kernel_options_post #299
Conversation
Hi @skycastlelily, changes look good. |
Sure,updated,thanks for your review:)
…On Thu, Oct 17, 2024 at 6:42 PM David Pascual ***@***.***> wrote:
Hi @skycastlelily <https://github.com/skycastlelily>, changes look good.
Could you please fix the flake8 warnings?
—
Reply to this email directly, view it on GitHub
<#299 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKFR23GAG23SYXFJ4EKLYTDZ36IB3AVCNFSM6AAAAABPXAY4EGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJZGE4DANRSGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@skycastlelily Hello, please see https://github.com/neoave/mrack/actions/runs/11395400988/job/31720359590?pr=299 for more small issues in a code. Also i think @dav-pascual would welcome the fixes to be included in first commit. |
Thanks for pointing that out.
Sorry, obviously I forgot to run pre-commit locally.
I made the summary shorter but clear enough,I ran pre-commit locally this
time, should be good now:)
…On Fri, Oct 18, 2024 at 4:23 PM Tibor Dudlák ***@***.***> wrote:
@skycastlelily <https://github.com/skycastlelily> Hello, please see
https://github.com/neoave/mrack/actions/runs/11395400988/job/31720359590?pr=299
for more small issues in a code. Also i think @dav-pascual
<https://github.com/dav-pascual> would welcome the fixes to be included
in first commit.
—
Reply to this email directly, view it on GitHub
<#299 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKFR23GY4Q64XCZGOHZAFZDZ4DAPNAVCNFSM6AAAAABPXAY4EGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRRHAYDSMZSHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
27ed79d
to
b5403ba
Compare
@skycastlelily test_beaker_transformer is failing. https://dev.azure.com/neoave/mrack/_build/results?buildId=1185&view=logs&jobId=e4354d11-29aa-59c2-ce04-0d9aced3ea05&j=e4354d11-29aa-59c2-ce04-0d9aced3ea05&t=c546a923-41d2-519e-602b-c74183bf4a4c Please, could you check pytest locally? |
b5403ba
to
2281399
Compare
Hi,sorry for the late reply, I was pretty busy with other stuff, I ran
pytest locally before I submitted this mr,it did fail, but after I git
checkout main, it also failed, as follows,so I submitted the mr.
FAILED
tests/unit/test_beaker_transformer.py::TestBeakerTransformer::test_beaker_requirement[meta_host2-exp_values2]
- AssertionError: Mismatch of transformed value and expected value[tasks]:
[{'name': '/distribution/dummy', 'role': 'STANDALONE'}] != [{'name':
'/distribution/dummy', 'role': 'STANDALONE', 'params':
['RSTRNT_DISABLED=10_avc_check']}]
I looked into the README of mrack, and run tox locally, main branch pass,
this mr failed.
Anyway, update this mr with the problem fixed, tox check pass locally , so
I guess we are finally really good now:)
…On Thu, Oct 24, 2024 at 10:48 PM David Pascual ***@***.***> wrote:
@skycastlelily <https://github.com/skycastlelily> test_beaker_transformer
is failing.
https://dev.azure.com/neoave/mrack/_build/results?buildId=1185&view=logs&jobId=e4354d11-29aa-59c2-ce04-0d9aced3ea05&j=e4354d11-29aa-59c2-ce04-0d9aced3ea05&t=c546a923-41d2-519e-602b-c74183bf4a4c
Please, could you check pytest locally?
—
Reply to this email directly, view it on GitHub
<#299 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKFR23E73XEHSSFIYOZRPILZ5ECCFAVCNFSM6AAAAABPXAY4EGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZVGUYDSNBXG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@skycastlelily Sorry for the late reply. All good, thank you :) |
No description provided.