test: Add add_dict_to_node test

neoave · May 14, 2024 · 2c0c2bb · 2c0c2bb
1 parent f4324bf
commit 2c0c2bb
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 3 deletions.
diff --git a/src/mrack/utils.py b/src/mrack/utils.py
@@ -172,10 +172,13 @@ def add_dict_to_node(node, input_dict):
                         child_node.appendChild(
                             add_dict_to_node(xml_doc().createElement(k), v)
                         )
-            if key.startswith("_"):
-                node.setAttribute(key[1:], str(value))
             else:
-                node.appendChild(add_dict_to_node(xml_doc().createElement(key), value))
+                if key.startswith("_"):
+                    node.setAttribute(key[1:], str(value))
+                else:
+                    node.appendChild(
+                        add_dict_to_node(xml_doc().createElement(key), value)
+                    )
 
     return node
 

diff --git a/tests/unit/test_utils.py b/tests/unit/test_utils.py
@@ -1,6 +1,9 @@
+from xml.dom.minidom import Document as xml_doc
+
 import pytest
 
 from mrack.utils import (
+    add_dict_to_node,
     get_fqdn,
     get_os_type,
     get_shortname,
@@ -170,3 +173,37 @@ def test_get_ssh_options(self, provisioning_config, metahost1):
     def test_ssh_options_to_cli(self, options, expected):
         """Test conversion of SSH options to CLI params."""
         assert ssh_options_to_cli(options) == expected
+
+    @pytest.mark.parametrize(
+        "req_node, dct, expected",
+        [
+            (
+                xml_doc().createElement("not"),
+                {
+                    "key_value": {
+                        "_key": "NETBOOT_METHOD",
+                        "_op": "like",
+                        "_value": "grub2",
+                    }
+                },
+                '<not><key_value key="NETBOOT_METHOD" op="like" value="grub2"/></not>',
+            ),
+            (
+                xml_doc().createElement("and"),
+                {
+                    "not": [
+                        {
+                            "key_value": {
+                                "_key": "BOOTDISK",
+                                "_op": "==",
+                                "_value": "dum",
+                            }
+                        },
+                    ]
+                },
+                '<and><not><key_value key="BOOTDISK" op="==" value="dum"/></not></and>',
+            ),
+        ],
+    )
+    def test_add_dict_to_node(self, req_node, dct, expected):
+        assert add_dict_to_node(req_node, dct).toxml() == expected