Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comply to ExecuteQuery ADR latest revision #1059

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Conversation

fbiville
Copy link
Contributor

@fbiville fbiville commented Feb 14, 2023

Align naming of the default bookmark manager getter with the prescribed one in the latest version of the ADR.

Allow filtering of records by skipping undefined results.
This avoid loading all mapped records into memory when some should be discarded.

Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦄

@bigmontz bigmontz merged commit 38f9ccc into 5.0 Feb 15, 2023
@bigmontz bigmontz deleted the execute_query_adr_updates branch February 15, 2023 14:51
bigmontz pushed a commit to bigmontz/neo4j-javascript-driver that referenced this pull request Mar 6, 2023
Align naming of the default bookmark manager getter with the prescribed one in the latest version of the ADR.

Allow filtering of records by skipping `undefined` results. 
This avoid loading all mapped records into memory when some should be discarded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants