Skip to content

Commit

Permalink
Update clirr configuration to check against previous version
Browse files Browse the repository at this point in the history
The `clirr-maven-plugin` configuration has been checking against `4.0.0` driver version for significant time. While it is useful in general, comparing against previous driver version (the default setting) has a benefit of making removals of public methods more visible in reviews.
  • Loading branch information
injectives committed Feb 22, 2023
1 parent 6dd7c0c commit de60a51
Show file tree
Hide file tree
Showing 7 changed files with 19 additions and 13 deletions.
2 changes: 1 addition & 1 deletion bundle/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.neo4j.driver</groupId>
<artifactId>neo4j-java-driver-parent</artifactId>
<version>5.5-SNAPSHOT</version>
<version>5.6-SNAPSHOT</version>
<relativePath>..</relativePath>
</parent>

Expand Down
6 changes: 6 additions & 0 deletions driver/clirr-ignored-differences.xml
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,12 @@
<method>org.neo4j.driver.BookmarkManager queryBookmarkManager()</method>
</difference>

<difference>
<className>org/neo4j/driver/Driver</className>
<differenceType>7002</differenceType>
<method>org.neo4j.driver.BookmarkManager queryBookmarkManager()</method>
</difference>

<difference>
<className>org/neo4j/driver/Driver</className>
<differenceType>7012</differenceType>
Expand Down
16 changes: 8 additions & 8 deletions driver/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.neo4j.driver</groupId>
<artifactId>neo4j-java-driver-parent</artifactId>
<version>5.5-SNAPSHOT</version>
<version>5.6-SNAPSHOT</version>
</parent>

<artifactId>neo4j-java-driver</artifactId>
Expand Down Expand Up @@ -164,17 +164,17 @@
<groupId>org.codehaus.mojo</groupId>
<artifactId>clirr-maven-plugin</artifactId>
<configuration>
<comparisonArtifacts>
<comparisonArtifact>
<groupId>org.neo4j.driver</groupId>
<artifactId>neo4j-java-driver</artifactId>
<version>4.0.0</version>
</comparisonArtifact>
</comparisonArtifacts>
<classesDirectory>${api.classes.directory}</classesDirectory>
<excludes>org/neo4j/driver/internal/**</excludes>
<ignoredDifferencesFile>clirr-ignored-differences.xml</ignoredDifferencesFile>
</configuration>
<dependencies>
<dependency>
<groupId>org.apache.bcel</groupId>
<artifactId>bcel</artifactId>
<version>6.7.0</version>
</dependency>
</dependencies>
</plugin>
</plugins>
</pluginManagement>
Expand Down
2 changes: 1 addition & 1 deletion examples/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.neo4j.driver</groupId>
<artifactId>neo4j-java-driver-parent</artifactId>
<version>5.5-SNAPSHOT</version>
<version>5.6-SNAPSHOT</version>
</parent>

<groupId>org.neo4j.doc.driver</groupId>
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

<groupId>org.neo4j.driver</groupId>
<artifactId>neo4j-java-driver-parent</artifactId>
<version>5.5-SNAPSHOT</version>
<version>5.6-SNAPSHOT</version>

<packaging>pom</packaging>
<name>Neo4j Java Driver Project</name>
Expand Down
2 changes: 1 addition & 1 deletion testkit-backend/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<parent>
<artifactId>neo4j-java-driver-parent</artifactId>
<groupId>org.neo4j.driver</groupId>
<version>5.5-SNAPSHOT</version>
<version>5.6-SNAPSHOT</version>
</parent>

<artifactId>testkit-backend</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion testkit-tests/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.neo4j.driver</groupId>
<artifactId>neo4j-java-driver-parent</artifactId>
<version>5.5-SNAPSHOT</version>
<version>5.6-SNAPSHOT</version>
<relativePath>..</relativePath>
</parent>

Expand Down

0 comments on commit de60a51

Please sign in to comment.