Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/empty and or #361

Merged
merged 3 commits into from
Jul 28, 2021
Merged

Fix/empty and or #361

merged 3 commits into from
Jul 28, 2021

Conversation

danstarns
Copy link
Contributor

Description

Fixes #360

darrellwarde
darrellwarde requested changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@darrellwarde darrellwarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! One of the tests just needs updating. 🙂

packages/graphql/tests/integration/issues/360.int.test.ts Outdated Show resolved Hide resolved
darrellwarde
darrellwarde approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@darrellwarde darrellwarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@darrellwarde darrellwarde merged commit 091d1ed into neo4j:master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrellwarde darrellwarde darrellwarde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing optional variable in AND statement generates invalid Cypher query
2 participants
@danstarns @darrellwarde