Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.0.0 #2773

Merged
merged 430 commits into from
Sep 1, 2023
Merged

4.0.0 #2773

merged 430 commits into from
Sep 1, 2023

Conversation

angrykoala
Copy link
Member

Description

Draft PR to keep track of diff between 4.0.0 and 3.x

@changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 00b626d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@neo4j/graphql Major
@neo4j/graphql-ogm Major
@neo4j/graphql-toolbox Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Jan 24, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@neo4j-team-graphql neo4j-team-graphql added documentation Improvements or additions to documentation graphql labels Jan 24, 2023
@neo4j-team-graphql
Copy link
Collaborator

neo4j-team-graphql commented Jan 24, 2023 •
edited
Loading

Performance Report

name dbHits old dbHits time (ms) old time (ms) maxRows
🟥 connections.ConnectionWithSortAndCypher 14278 2277 88 273 2174
🟦 cypher-directive.TopLevelMutationDirective 1135 N/A 23 N/A 1134
🟥 sorting.SortMultipleTypesWithCypherWithCypher 13452 1392 87 210 2174
🟥 sorting.SortWithTopLevelCypher 14120 2119 52 154 2174

🟥 - Performance worsened (dbHits)
🟩 - Performance improved (dbHits)
🟦 - New test

Show Full Table
name dbHits old dbHits time (ms) old time (ms) maxRows
aggregations.TopLevelAggregate 3403 3403 31 77 1134
aggregations.NestedAggregation 13514 13514 87 112 2174
aggregations.AggregationWithWhere 10942 10942 63 90 2174
aggregations.NestedCountFromMovieToActors 8694 8694 68 112 2174
aggregations.NestedCountFromActorsToMovie 8900 8900 101 75 2174
aggregations.DeeplyNestedCount 10054408 10054408 4124 4088 2008534
batch-create.BatchCreate 3600 3600 97 105 600
connect.createAndConnect 12419 12419 299 266 3003
connections.Connection 13042 13042 156 121 2174
connections.NestedConnection 33883 33883 156 132 4516
connections.ConnectionWithSort 2277 2277 55 81 1040
🟥 connections.ConnectionWithSortAndCypher 14278 2277 88 273 2174
create.SimpleMutation 6 6 26 38 1
🟦 cypher-directive.TopLevelMutationDirective 1135 N/A 23 N/A 1134
delete.SimpleDelete 18361 18361 303 243 1040
delete.NestedDeleteInUpdate 16779 16779 93 146 2040
query.SimpleQuery 14120 14120 186 151 2174
query.QueryWhere 8656 8663 32 114 2160
query.SimpleQueryWithNestedWhere 8827 8834 47 53 2160
query.Nested 10084290 10084290 9619 8902 2008534
query.NestedWithFilter 37172 37172 140 213 4511
query.OrFilterOnRelationships 36892 37335 156 181 1781
query.OrFilterOnRelationshipsAndNested 30145 31423 174 248 1781
query.QueryWithNestedIn 12227 12527 118 62 1177
query.NestedConnectionWhere 8794 8794 105 58 2174
query.DeeplyNestedConnectionWhere 9054 8989 72 79 2174
query.DeeplyNestedWithRelationshipFilters 6251 6251 112 139 1134
query.DeeplyNestedWithRelationshipSingleFilters 15438 15438 90 118 2174
query.Fulltext 96 96 37 27 16
query.FulltextWithNestedQuery 571 571 41 42 84
sorting.SortMultipleTypes 2493 2493 57 66 1040
🟥 sorting.SortMultipleTypesWithCypherWithCypher 13452 1392 87 210 2174
sorting.SortOnNestedFields 13042 13042 97 97 2174
sorting.SortDeeplyNestedFields 38965 38965 165 146 4516
🟥 sorting.SortWithTopLevelCypher 14120 2119 52 154 2174
unions.SimpleUnionQuery 321 321 58 63 35
unions.SimpleUnionQueryWithMissingFields 293 293 87 55 35
unions.NestedUnion 398553 398553 344 291 33033
unions.NestedUnionWithMissingFields 372527 372527 290 315 33033
update.NestedUpdate 2119 2119 39 49 1040

Old Schema Generation: 26.688s
Schema Generation: 26.975s

@angrykoala angrykoala temporarily deployed to npm January 24, 2023 12:17 — with GitHub Actions Inactive
@angrykoala angrykoala temporarily deployed to npm January 24, 2023 14:34 — with GitHub Actions Inactive
@angrykoala angrykoala temporarily deployed to npm January 30, 2023 14:36 — with GitHub Actions Inactive
@angrykoala angrykoala temporarily deployed to npm January 30, 2023 16:09 — with GitHub Actions Inactive
@angrykoala angrykoala temporarily deployed to npm January 30, 2023 17:47 — with GitHub Actions Inactive
@angrykoala angrykoala temporarily deployed to npm January 30, 2023 17:50 — with GitHub Actions Inactive
@angrykoala angrykoala temporarily deployed to npm January 30, 2023 18:05 — with GitHub Actions Inactive
@angrykoala angrykoala temporarily deployed to npm February 2, 2023 09:45 — with GitHub Actions Inactive
@angrykoala angrykoala temporarily deployed to npm February 2, 2023 11:07 — with GitHub Actions Inactive
@angrykoala angrykoala temporarily deployed to npm February 2, 2023 11:16 — with GitHub Actions Inactive
@a-alle a-alle temporarily deployed to npm February 3, 2023 17:19 — with GitHub Actions Inactive
@neo4j-team-graphql
Copy link
Collaborator

Looks like you've updated the documentation!

Check out your changes at https://neo4j-graphql-docs-2773.surge.sh

@neo4j-team-graphql
Copy link
Collaborator

neo4j-team-graphql commented Feb 3, 2023 •
edited
Loading

Thanks for the Neo4j GraphQL Toolbox updates.

The Neo4j GraphQL Toolbox has now been torn down - reopening this PR will republish it.

@a-alle a-alle temporarily deployed to npm February 3, 2023 17:30 — with GitHub Actions Inactive
@neo4j-team-graphql
Copy link
Collaborator

neo4j-team-graphql commented Feb 3, 2023 •
edited
Loading

Performance Report

name dbHits old dbHits time (ms) old time (ms) maxRows
🟥 connections.ConnectionWithSortAndCypher 16325 3284 110 437 2174
🟦 cypher-directive.TopLevelMutationDirective 1135 N/A 55 N/A 1134
🟩 delete.NestedDeleteInUpdate 19198 23202 326 295 1183
🟥 sorting.SortMultipleTypesWithCypherWithCypher 14464 1482 161 317 2174

🟥 - Performance worsened (dbHits)
🟩 - Performance improved (dbHits)
🟦 - New test

Show Full Table
name dbHits old dbHits time (ms) old time (ms) maxRows
aggregations.TopLevelAggregate 3403 3403 47 52 1134
aggregations.NestedAggregation 16553 16553 79 105 2174
aggregations.AggregationWithWhere 11979 11979 54 67 2174
aggregations.AggregationWhereWithinNestedRelationships 22116987 22116987 3336 3796 2008534
aggregations.AggregationWhereWithinNestedConnections 22116987 22116987 3462 3318 2008534
aggregations.NestedCountFromMovieToActors 9734 9734 57 76 2174
aggregations.NestedCountFromActorsToMovie 9937 9937 55 71 2174
aggregations.DeeplyNestedCount 13070439 13070331 5654 6076 2008534
batch-create.BatchCreate 4200 4200 219 172 600
batch-create.BatchCreateSmall 77 77 160 85 11
connect.createAndConnect 14424 14424 216 229 3003
connections.Connection 14082 14082 70 82 2174
connections.NestedConnection 45472 45472 134 143 4516
connections.ConnectionWithSort 3284 3284 85 96 1040
🟥 connections.ConnectionWithSortAndCypher 16325 3284 110 437 2174
create.SimpleMutation 7 7 69 81 1
🟦 cypher-directive.TopLevelMutationDirective 1135 N/A 55 N/A 1134
delete.SimpleDelete 19401 19401 312 321 1040
🟩 delete.NestedDeleteInUpdate 19198 23202 326 295 1183
2925.SingleRelationshipFilter 6468 6468 64 65 1040
2925.NestedSingleRelationshipFilter 22900 22900 108 136 2174
2925.SingleRelationshipRequiredFilter 5201 5201 68 62 1040
2925.NestedSingleRelationshipRequiredFilter 9361 9361 71 78 1040
query.SimpleQuery 3121 3121 30 40 1040
query.SimpleQueryWithRelationship 16162 16162 53 68 2174
query.QueryWhere 9712 9707 46 58 2166
query.SimpleQueryWithNestedWhere 9890 9885 65 73 2166
query.Nested 10096041 10096041 11374 11957 2008534
query.NestedWithFilter 10074401 10074401 11500 12079 2004000
query.OrFilterOnRelationships 43542 43241 250 300 1950
query.OrFilterOnRelationshipsAndNested 37083 36771 375 358 1950
query.QueryWithNestedIn 14051 15145 106 109 1433
query.NestedConnectionWhere 9834 9834 100 84 2174
query.DeeplyNestedConnectionWhere 9851 10069 97 256 2174
query.DeeplyNestedWithRelationshipFilters 18996 19302 170 234 1552
query.NestedWithRelationshipSingleFilters 3881 3881 207 294 1134
query.Fulltext 80 80 43 48 16
query.FulltextWithNestedQuery 587 587 59 74 84
sorting.SortMultipleTypes 3515 3515 99 103 1040
🟥 sorting.SortMultipleTypesWithCypherWithCypher 14464 1482 161 317 2174
sorting.SortOnNestedFields 14082 14082 73 75 2174
sorting.SortDeeplyNestedFields 43198 43198 126 133 4516
sorting.SortWithTopLevelCypher 3396 3121 83 84 1040
unions.SimpleUnionQuery 321 321 78 105 35
unions.SimpleUnionQueryWithMissingFields 293 293 94 90 35
unions.NestedUnion 410637 410637 449 561 33033
unions.NestedUnionWithMissingFields 384611 384611 312 481 33033
update.NestedUpdate 16143 16143 128 155 2002

Old Schema Generation: 1:01.673 (m:ss.mmm)
Schema Generation: 58.800s
Old Subgraph Schema Generation: 1:10.131 (m:ss.mmm)
Subgraph Schema Generation: 1:10.222 (m:ss.mmm)

@darrellwarde darrellwarde temporarily deployed to npm February 6, 2023 17:12 — with GitHub Actions Inactive
@a-alle a-alle temporarily deployed to npm February 6, 2023 18:12 — with GitHub Actions Inactive
@darrellwarde darrellwarde temporarily deployed to npm February 10, 2023 12:23 — with GitHub Actions Inactive
@darrellwarde darrellwarde temporarily deployed to npm February 13, 2023 08:53 — with GitHub Actions Inactive
a-alle and others added 4 commits August 31, 2023 18:16
@a-alle
fix skip test
fb4bd2e
@a-alle
fix missing directives
c993934
@a-alle
improve jwt directives rule to check for adding jwt on extension as l…
e030dce 
…ast thing
@darrellwarde
Fix: cypherParams in context now work as expected when using OGM (#…
8ac6d88 
…3830)

* Fix: `cypherParams` in context now work as expected when using OGM

* Remove jwt and token from OGM context types

* Change test to use cypherParams

* Update typing
@darrellwarde darrellwarde temporarily deployed to npm September 1, 2023 09:30 — with GitHub Actions Inactive
@a-alle a-alle temporarily deployed to npm September 1, 2023 10:55 — with GitHub Actions Inactive
@darrellwarde darrellwarde temporarily deployed to npm September 1, 2023 12:33 — with GitHub Actions Inactive
@darrellwarde darrellwarde marked this pull request as ready for review September 1, 2023 12:33
@darrellwarde darrellwarde temporarily deployed to npm September 1, 2023 12:38 — with GitHub Actions Inactive
@darrellwarde darrellwarde temporarily deployed to npm September 1, 2023 12:42 — with GitHub Actions Inactive
@darrellwarde darrellwarde merged commit 7462b97 into dev Sep 1, 2023
87 checks passed
@neo4j-team-graphql neo4j-team-graphql mentioned this pull request Sep 1, 2023
Merged
@darrellwarde darrellwarde deleted the 4.0.0 branch September 6, 2023 08:13
@angrykoala angrykoala restored the 4.0.0 branch September 6, 2023 12:16
@angrykoala angrykoala temporarily deployed to npm September 6, 2023 12:16 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@darrellwarde darrellwarde Awaiting requested review from darrellwarde darrellwarde is a code owner

@tbwiss tbwiss Awaiting requested review from tbwiss tbwiss is a code owner

@mjfwebb mjfwebb Awaiting requested review from mjfwebb mjfwebb is a code owner

@MacondoExpress MacondoExpress Awaiting requested review from MacondoExpress MacondoExpress is a code owner

@a-alle a-alle Awaiting requested review from a-alle a-alle is a code owner

@Liam-Doodson Liam-Doodson Awaiting requested review from Liam-Doodson Liam-Doodson is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation introspector ogm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@angrykoala @CLAassistant @neo4j-team-graphql @darrellwarde @MacondoExpress @mjfwebb @a-alle @Liam-Doodson @lidiazuin