LIMIT: Invalid input. '10.0' is not a valid value. Must be a non-negative integer.",

[reaperdtme]

Describe the bug
Simple query on a model with a limit or skip parameter in the gql query

query Patients($where: PatientWhere!, $options: PatientOptions) {
  patients(where: $where, options: $options) {
    id
    firstName
    middleName
    lastName
  }
}

{
	"where": {},
	"options": {
                 "limit": 10,
		"sort": [
			{
				"lastName": "ASC"
			}
		]
	}
}

Expected behavior
Skip and limit to work

System (please complete the following information):
"@neo4j/graphql": "^1.0.1"
"@neo4j/graphql-ogm": "^1.0.1"
"neo4j-driver": "^4.2.3",
Neo4J: Version 1.4.3 (1.4.3.49)

Additional context
After editing this line

graphql/packages/graphql/src/translate/translate-read.ts

Line 113 in eb4d0c1

cypherParams[`${varName}_limit`] = optionsInput.limit;

to be

cypherParams[`${varName}_limit`] = neo4j.int(optionsInput.limit)

The query successfully runs

[darrellwarde]

This is sadly not just a single-fix solution - this is linked to both #186 and #167. As such, sadly it is not such a simple solution, but we are on it and will be addressing this ASAP!

[oskarhane]

@aspectgfg Hi, to make sure we cover all the cases and setups when looking into this, can I ask you to create a repo or example setup where you see this behavior?
Out of the box without any other dependencies this is not an issue, that's why it's important to us to see what the different setups where this happens looks like.

[darrellwarde]

A fix (hopefully!) for this has now been merged, and will be released shortly (aiming for tomorrow). Please do test and feel free to reopen this ticket if it hasn't addressed your problems! 🙂

[darrellwarde]

After much back and forth of thinking we had fixed this bug, it should finally be fully fixed by #297. 🤞 Apologies it took a while to get to this stage, it was a tricky bug to find but then very clear once we had found it!