Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integer input parsing #230

Merged

Conversation

darrellwarde
Copy link
Contributor

@darrellwarde darrellwarde commented Jun 2, 2021

Description

Remove the parse function of the Int scalar, and instead modify the resolve tree used to generate Cypher, replacing any integer values with Neo4j Integer values, which are checked against the schema to ensure they are of the correct type.

Issue

Checklist

The following requirements should have been met (depending on the changes in the branch):

  • Documentation has been updated
  • TCK tests have been updated
  • Integration tests have been updated
  • Example applications have been updated
  • New files have copyright header
  • CLA (https://neo4j.com/developer/cla/) has been signed

@darrellwarde
Copy link
Contributor Author

darrellwarde commented Jun 2, 2021

In lieu of testing due to inability to reproduce, sent a build of this branch to @tlester who confirmed that his problems with Int values are no more!

@darrellwarde darrellwarde merged commit a6fbe2f into neo4j:master Jun 2, 2021
@darrellwarde darrellwarde deleted the bugfix/int-float-serialization branch May 9, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants