Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing reset method in Neo4jDataCollector #43

Merged
merged 4 commits into from
Jan 22, 2018
Merged

Implementing reset method in Neo4jDataCollector #43

merged 4 commits into from
Jan 22, 2018

Conversation

angelov
Copy link
Contributor

@angelov angelov commented Dec 14, 2017 •
edited
Loading

When upgrading Symfony to 3.4, the following deprecation notice is given:

Implementing "Symfony\Component\HttpKernel\DataCollector\DataCollectorInterface" without the 
"reset()" method is deprecated since version 3.4 and will be unsupported in 4.0 for class 
"Neo4j\Neo4jBundle\Collector\Neo4jDataCollector"

I'm not sure if the resetting of the QueryLogger is actually needed.

@magicuniverse-azeem magicuniverse-azeem mentioned this pull request Jan 22, 2018
Closed
Nyholm
Nyholm approved these changes Jan 22, 2018
View reviewed changes
Copy link
Collaborator

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Nyholm Nyholm merged commit 800a060 into neo4j-php:master Jan 22, 2018
@xavismeh
Copy link
Collaborator

👍

@angelov angelov deleted the method-reset branch February 13, 2018 13:34
@angelov angelov restored the method-reset branch February 13, 2018 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@angelov @xavismeh @Nyholm