This repository has been archived by the owner on Sep 3, 2021. It is now read-only.
Fixing augmentation testing with related issues #369 & #370 #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream merge
removed location _asc and _desc from _MovieOrdeing given the blocking of ordering support for Point type fields Added generated types missing from previous augmentation test updates Updated compareSchema to fix it incorrectly iterating through the definitions arrays from the two schemas being compared
The augmentation process was generating output types for relationship update mutations even when that relationship has no properties to update. Some logic was previously added to prevent the generation of such an update mutation field, but the same logic was not yet applied to the generation of associated output types.
There is no intended support for translating `_asc` or `_desc` ordering arguments for `Point` type fields. Initial support for the `Point` type Query API was meant to prevent the generation of such values, but did not.
Codecov Report
@@ Coverage Diff @@
## master #371 +/- ##
======================================
Coverage 96.3% 96.3%
======================================
Files 24 24
Lines 2844 2844
======================================
Hits 2739 2739
Misses 105 105
Continue to review full report at Codecov.
|
johnymontana
approved these changes
Jan 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
compareSchemafunction used intest/augmentSchemaTest.test.jshad an issue that prevented it from checking for the existence of some generated types. The function and the expected schema for the augmentation test has been updated. Upon the discovery of this issue, I also discovered and tried to resolve two issues in the augmentation process, #369 and #370.