Skip to content
This repository has been archived by the owner on Sep 3, 2021. It is now read-only.

Fix bug where Camel/Pascal cased variables were broken in filters #325

Merged

Conversation

whostolebenfrog
Copy link
Contributor

This fixes a bug where if types had a cased name e.g. MovieWithCase then it would be incorrectly referred to later in the query resulting in both an unbounded match and incorrect results.

I believe this should resolve these two open issues:

#309
#257

@codecov-io
Copy link

Codecov Report

Merging #325 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #325   +/-   ##
======================================
  Coverage    95.4%   95.4%           
======================================
  Files          10      10           
  Lines        2350    2350           
======================================
  Hits         2242    2242           
  Misses        108     108
Impacted Files Coverage Δ
src/translate.js 98.64% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70e6966...1fbcbd6. Read the comment docs.

@johnymontana
Copy link
Contributor

Perfect - thanks @whostolebenfrog!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants