-
Notifications
You must be signed in to change notification settings - Fork 147
Write CONTRIBUTING.md that would have helped me #250
Write CONTRIBUTING.md that would have helped me #250
Conversation
I like that @johnymontana has closed my pull request here: neo4j-graphql#243 I don't find the standard CONTRIBUTING guidelines very helpful either. The only thing that I like to re-use is a hint how to join the neo4j community on Slack. I guess that would be the best option for new contributors to get some guidance. So in this commit I tried to document issues and my workarounds that I discovered already. I hope other people find this useful.
Codecov Report
@@ Coverage Diff @@
## master #250 +/- ##
=======================================
Coverage 94.47% 94.47%
=======================================
Files 4 4
Lines 326 326
=======================================
Hits 308 308
Misses 18 18 Continue to review full report at Codecov.
|
following requirements: | ||
|
||
- A local Neo4J instance with username `neo4j` and password `letmein` | ||
- Your Neo4J instance runs on [this database](https://s3.amazonaws.com/neo4j-sandbox-usecase-datastores/v3_5/recommendations.db.zip) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnymontana thank you for providing the file. Could you upload a dump of your database to s3.amazonaws.com..
?
neo4j-admin dump --to=./recommendations-db
# upload recommendations-db to amazon aws
We could improve the documentation here and use neo4j-admin load ...
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By now I would prefer to check the file into version control. Opinions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer not to check the datastore into git. Let's plan for a long term goal of refactoring the tests to use Cypher script fixtures rather than loading the datastore.
In the meantime a .dump
version of the datastore is available here: https://s3-us-west-2.amazonaws.com/neo4j-datasets-public/recommendations.dump
Thanks for the guide :) |
I like that @johnymontana has closed my pull request here:
#243
I don't find the standard CONTRIBUTING guidelines very helpful either.
The only thing that I like to re-use is a hint how to join the neo4j
community on Slack. I guess that would be the best option for new
contributors to get some guidance.
So in this commit I tried to document issues and my workarounds that I
discovered already. I hope other people find this useful.
close #248