Skip to content
This repository has been archived by the owner on Sep 3, 2021. It is now read-only.

bugfix: custom mutation cypher params not being passed #246

Merged
merged 1 commit into from
May 20, 2019
Merged

bugfix: custom mutation cypher params not being passed #246

merged 1 commit into from
May 20, 2019

Conversation

a-type
Copy link
Contributor

@a-type a-type commented May 18, 2019

When writing a custom Cypher mutation using the @cypher directive, cypherParams would not be passed down into field selections with nested @cypher directives. It seems that the cypherParams parameter was omitted from buildCypherSelection (unlike customQuery, which does pass it properly).

Added a unit test to avoid regressions.

@codecov-io
Copy link

codecov-io commented May 18, 2019

Codecov Report

Merging #246 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #246   +/-   ##
=======================================
  Coverage   94.47%   94.47%           
=======================================
  Files           4        4           
  Lines         326      326           
=======================================
  Hits          308      308           
  Misses         18       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af92564...377a11e. Read the comment docs.

Copy link
Contributor

@johnymontana johnymontana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@johnymontana
Copy link
Contributor

Thanks @a-type!

@johnymontana johnymontana merged commit be051fe into neo4j-graphql:master May 20, 2019
@a-type a-type deleted the fix-custom-mutation-cypher-params branch May 21, 2019 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants