Clean memory #868
Merged
Clean memory #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #868 +/- ##
==========================================
- Coverage 43.57% 43.57% -0.01%
==========================================
Files 177 177
Lines 12547 12552 +5
==========================================
+ Hits 5467 5469 +2
- Misses 7080 7083 +3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #868 +/- ##
==========================================
- Coverage 43.57% 43.54% -0.03%
==========================================
Files 177 177
Lines 12547 12559 +12
==========================================
+ Hits 5467 5469 +2
- Misses 7080 7090 +10
Continue to review full report at Codecov.
|
erikzhang
reviewed
Jun 26, 2019
erikzhang
approved these changes
Jun 26, 2019
vncoelho
reviewed
Jun 26, 2019
|
@vncoelho I think that we need to port this to 2x, do you want to do it? |
Thacryba
pushed a commit
to simplitech/neo
that referenced
this pull request
Feb 17, 2020
* fix issue neo-project#868 * Update claimgas.md
Tommo-L
pushed a commit
to Tommo-L/neo
that referenced
this pull request
Jun 22, 2020
* Clean memory * Other * Other * Update Wallet.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually we clean the buffer where the private key was copied, as here
neo/neo/Wallets/KeyPair.cs
Line 51 in c64748e
But we forgot to clean these buffers.