Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store transaction result #864

Merged
merged 2 commits into from
Jun 26, 2019
Merged

Conversation

shargon
Copy link
Member

@shargon shargon commented Jun 25, 2019

No description provided.

@shargon shargon requested a review from erikzhang June 25, 2019 11:21
@codecov-io
Copy link

codecov-io commented Jun 25, 2019

Codecov Report

Merging #864 into master will decrease coverage by 0.01%.
The diff coverage is 41.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #864      +/-   ##
==========================================
- Coverage   43.57%   43.56%   -0.02%     
==========================================
  Files         177      177              
  Lines       12547    12555       +8     
==========================================
+ Hits         5467     5469       +2     
- Misses       7080     7086       +6
Impacted Files Coverage Δ
neo/Ledger/TransactionState.cs 0% <0%> (ø) ⬆️
neo/Ledger/Blockchain.cs 37.59% <100%> (+0.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31bee40...4214642. Read the comment docs.

@vncoelho vncoelho requested a review from igormcoelho June 25, 2019 14:40
igormcoelho
igormcoelho previously approved these changes Jun 25, 2019
Copy link
Contributor

@igormcoelho igormcoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice info for block imports exports. Do you think an interop get tx result is useful?

@shargon
Copy link
Member Author

shargon commented Jun 25, 2019

Yes, will be good to know if one tx was fault

@erikzhang erikzhang added this to the NEO 3.0 milestone Jun 26, 2019
@shargon shargon merged commit 67aa682 into neo-project:master Jun 26, 2019
@shargon shargon deleted the store-tx-result branch June 26, 2019 09:25
Tommo-L pushed a commit to Tommo-L/neo that referenced this pull request Jun 22, 2020
* Store transaction result

* optimize
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants