-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing Storage.Add on verification mempool cache #820
Implementing Storage.Add on verification mempool cache #820
Conversation
Just to explain what I'm trying to do... right now, to make it easier, I created two interops: |
As advised by @ricklock9 (#814 (comment)) perhaps a better interface is something like |
… into feat_3x_storage_intcache
Codecov Report
@@ Coverage Diff @@
## master #820 +/- ##
==========================================
- Coverage 38.41% 38.36% -0.06%
==========================================
Files 176 176
Lines 12459 12479 +20
==========================================
+ Hits 4786 4787 +1
- Misses 7673 7692 +19
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #820 +/- ##
==========================================
- Coverage 38.41% 38.41% -0.01%
==========================================
Files 176 176
Lines 12459 12496 +37
==========================================
+ Hits 4786 4800 +14
- Misses 7673 7696 +23
Continue to review full report at Codecov.
|
@shargon @erikzhang this is the core of the idea... not complete yet, but given an overview of the changes needed on Nep5Token class. Can you take a look please, just to evaluate the direction? |
Not feasible anymore... however, lead to nice improvements, such as garbage collection and dettached TState objects ;) |
Draft implementation for: #814