-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for ProtocolHandler Mailboxes (Neo 3.x) #809
Tests for ProtocolHandler Mailboxes (Neo 3.x) #809
Conversation
@vncoelho please apply your fix. |
Brother, the fix was already applied. |
These tests are not easy to be made! Nice templates, @igormcoelho. Great job. |
Codecov Report
@@ Coverage Diff @@
## master #809 +/- ##
==========================================
+ Coverage 37.73% 37.85% +0.12%
==========================================
Files 176 176
Lines 12445 12445
==========================================
+ Hits 4696 4711 +15
+ Misses 7749 7734 -15
Continue to review full report at Codecov.
|
Where is the tests :P ? I only see for |
uut.IsHighPriority(Message.Create(MessageCommand.Transaction, s)).Should().Be(false); | ||
uut.IsHighPriority(Message.Create(MessageCommand.Block, s)).Should().Be(false); | ||
uut.IsHighPriority(Message.Create(MessageCommand.Consensus, s)).Should().Be(true); | ||
uut.IsHighPriority(Message.Create(MessageCommand.Reject, s)).Should().Be(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here the tests @shargon! hahaha
Focused on ProtocolHandler this time... Coverage increased a lot already, and on future we cover others ;)
Changed title now :P |
later I can try to.finish all. |
Dont accept yet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can finish in another PR, Igor.
Ok then, I have to do for 2x as well.. it will help Ricardo. |
* 部署和调用智能合约 wrong link cant goto 部署和调用智能合约 page cause of missing "zh-cn" * add sc migrate * format code * update
* [EN] Sync up with neo-project#809 [EN] Sync up with neo-project#809 * minor update * fix some
* tests for mailboxes on 3x * Fixing UT to MessageCommand * Fixing string * Explicit Byte * MessageCommand with random byte * space * testing all cases * Update UT_ConsensusServiceMailbox.cs * Update UT_RemoteNodeMailbox.cs * Update UT_TaskManagerMailbox.cs
Basic unit tests for Mailboxes.