VersionPayload optimization #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shargon
commented
May 17, 2019
shargon
commented
May 17, 2019
vncoelho
reviewed
May 17, 2019
|
|
||
| namespace Neo.Network.P2P.Capabilities | ||
| { | ||
| public class FullNodeCapability : NodeCapability |
There was a problem hiding this comment.
This full node capability only with start height is quite strange.
There was a problem hiding this comment.
FullNodeCapability means the node has full blockchain data and accept relay.
There was a problem hiding this comment.
If you are a relay node, why you should provide a 0 or this information?
erikzhang
previously approved these changes
May 17, 2019
vncoelho
reviewed
May 17, 2019
erikzhang
approved these changes
May 17, 2019
Thacryba
pushed a commit
to simplitech/neo
that referenced
this pull request
Feb 17, 2020
Thacryba
pushed a commit
to simplitech/neo
that referenced
this pull request
Feb 17, 2020
* RU: synced PR neo-project#751 * RU: synced PR neo-project#755 * RU: synced PR neo-project#754
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #728 without udp