Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve LevelDBStore #3607

Merged
merged 7 commits into from
Dec 5, 2024
Merged

Conversation

cschuchardt88
Copy link
Member

Change Log

  • Added GetEnumerator to DB, Store and Snapshot
  • Change UIntPtr/IntPtr to nuint/nint
  • Change name from GetSnapshot to CreateSnapshot
  • Changed name from NewIterator to CreateIterator
  • Added DB unit tests

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • TestLevelDb
  • TestLevelDbDatabase
  • TestLevelDbMultiSnapshot
  • TestLevelDbSnapshot

Test Configuration:

  • Unit Tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Jim8y
Jim8y previously approved these changes Dec 3, 2024
@cschuchardt88 cschuchardt88 requested a review from nan01ab December 3, 2024 16:32
@nan01ab
Copy link
Contributor

nan01ab commented Dec 4, 2024

LGTM

Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any benefit of allow to iterate without a snapshot, but if it's ok for all except me, I'm not against to

@Jim8y
Copy link
Contributor

Jim8y commented Dec 5, 2024

I don't see any benefit of allow to iterate without a snapshot, but if it's ok for all except me, I'm not against to

I think it is not a thing about benefit, but more about coding style and class completeness.

@NGDAdmin NGDAdmin merged commit cc2ad03 into neo-project:master Dec 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants