-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve LevelDBStore
#3607
Improve LevelDBStore
#3607
Conversation
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any benefit of allow to iterate without a snapshot, but if it's ok for all except me, I'm not against to
I think it is not a thing about benefit, but more about coding style and class completeness. |
Change Log
GetEnumerator
toDB
,Store
andSnapshot
UIntPtr
/IntPtr
tonuint
/nint
GetSnapshot
toCreateSnapshot
NewIterator
toCreateIterator
DB
unit testsType of change
How Has This Been Tested?
TestLevelDb
TestLevelDbDatabase
TestLevelDbMultiSnapshot
TestLevelDbSnapshot
Test Configuration:
Checklist: