[Move] Part-7 Classes into Different Library - Neo.Extensions
#3446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`, `AssemblyExtensions`, `StringExtensdions` Deleted `Helper.cs` file
…8/neo into rebuild/the-split-2
Hecate2
reviewed
Aug 5, 2024
Comment on lines
18
to
28
| public static void Remove<T>(this HashSet<T> set, ISet<T> other) | ||
| { | ||
| if (set.Count > other.Count) | ||
| { | ||
| set.ExceptWith(other); | ||
| } | ||
| else | ||
| { | ||
| set.RemoveWhere(u => other.Contains(u)); | ||
| } | ||
| } |
There was a problem hiding this comment.
( Does set.Remove(other) have any difference from set.ExceptWith(other), even when set.Count <= other.Count? )
There was a problem hiding this comment.
No clue. I'm just moving the method to appropriate namespaces or libraries.
|
@cschuchardt88 please fix conflics, is this one the current blocker? |
|
Awaiting on |
Jim8y
added
Blocker
|
@cschuchardt88 please fix the conflicts. |
|
@Jim8y done, fixed all merging errors |
shargon
reviewed
Nov 26, 2024
shargon
reviewed
Nov 26, 2024
| if (parameter.Value is BigInteger bi) | ||
| builder.EmitPush(bi); | ||
| else | ||
| builder.EmitPush((BigInteger)typeof(BigInteger).GetConstructor([parameter.Value.GetType()]).Invoke([parameter.Value])); |
There was a problem hiding this comment.
Can we change this ugly old code?
There was a problem hiding this comment.
I rather leave for another pr.
Jim8y
approved these changes
Nov 28, 2024
Jim8y
added
Ready to Merge
and removed
Blocker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reorganized and move classes from
neolibrary toneo.extensionslibrary.Fixed problems and warnings that occurred. Along with naming violations.
Change Log
Neo.VM.HelperclassScriptBuilderExtensionsclassusingstatementStringExtensionsclass and filenameType of change
How Has This Been Tested?
Checklist: