Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Move] Part-6 Classes into Different Library - Neo.Extensions #3410

Merged
merged 57 commits into from
Nov 25, 2024

Conversation

cschuchardt88
Copy link
Member

Description

Reorganized and move classes from neo library to neo.extensions library.

Fixed problems and warnings that occurred. Along with naming violations.

Change Log

  • Moved methods from Neo.IO.Helper class
  • Added BinaryReaderExtensions, BinaryWriterExtensions, MemoryReaderExtensions, SpanExtensions classes
  • Added more methods to StringExtensions, ByteExtensions MemoryExtensions
  • Added using statement
  • Fixed unit tests

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit Testing

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cschuchardt88 cschuchardt88 requested review from shargon and Jim8y July 7, 2024 19:31
@cschuchardt88 cschuchardt88 added Blocked This issue can't be worked at the moment Waiting for Review labels Jul 7, 2024
/// </summary>
/// <param name="data">The compressed data.</param>
/// <param name="maxOutput">The maximum data size after decompression.</param>
/// <returns>The original data.</returns>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that adding new methods will make it easier to do the work, and actually it wont cause any trouble, but please avoid doing so.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, please don't add if the PR is so big and is not related with this

Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@superboyiii could you check if there are any storage change in both networks?

@superboyiii
Copy link
Member

@superboyiii could you check if there are any storage change in both networks?

Sure

@superboyiii
Copy link
Member

superboyiii commented Nov 19, 2024

Mainnet test result shows it's compatible. I will try testnet as well.

@superboyiii
Copy link
Member

Data is compatible on testnet as well.

@shargon shargon merged commit b2cbfc0 into neo-project:master Nov 25, 2024
6 of 7 checks passed
@Jim8y Jim8y deleted the rebuild/the-split-6 branch November 25, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocker Issues that are blocking other issues. Check issues details to see what it is blocking. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants