[Neo Plugins UT] Add RpcServer Unit Tests Part Blockchain. #3339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Fixed pathing and Property (neo-project#3306) [Neo CLI New Feature] Allow custom plugins (neo-project#3295) Return expect to verify neo-cli (neo-project#3318) [Neo CLI Optimization] fix exception message (neo-project#3314) fix plugin download url (neo-project#3329)
Jim8y
requested review from
shargon,
cschuchardt88,
AnnaShaleva,
vncoelho and
roman-khimov
5 tasks
Jim8y
changed the title
|
How come the test coverage decreased 20%,,,, while i just aded tests in this pr..... |
shargon
reviewed
Jun 16, 2024
14 tasks
NGDAdmin
previously approved these changes
Jun 20, 2024
cschuchardt88
previously approved these changes
Jun 20, 2024
shargon
previously approved these changes
Jun 20, 2024
AnnaShaleva
reviewed
Jun 24, 2024
| /// An array containing the transaction hash as the first element, | ||
| /// and an optional boolean indicating whether to return verbose information. | ||
| /// </param> | ||
| /// <returns>The transaction data as a <see cref="JToken"/>. In json format if the second item of _params is true, otherwise base64string. </returns> |
There was a problem hiding this comment.
I see the base64string pattern being repeated, so it's probably intentionally.
Co-authored-by: Anna Shaleva <[email protected]>
Co-authored-by: Anna Shaleva <[email protected]>
Co-authored-by: Anna Shaleva <[email protected]>
Co-authored-by: Anna Shaleva <[email protected]>
Co-authored-by: Anna Shaleva <[email protected]>
cschuchardt88
approved these changes
Jun 27, 2024
shargon
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Neo Plugins lack unit tests, making it not clear whether our update to the code has changed any existing functionality or not. Thus having this pr to standard the plugin rpcserver method behavior.
Fixes # #3339
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: