[Neo Core Style] Rename parameters, update comments, fix code style #3294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr is mainly intended to rename the
index
toblockHeight
. Reason of making this update is because when we usethe second parameter is confusing, as native contract itself has a field Id, sort of confusing to people who is not familer with neo as core-devs. Well, i am also lost for a while thought shargon was passing the contract id/index in the devpack test engine.
And to avoid this pr be a
single line pr
, I also fixed some style issues, and a nullable issue here:As
Concat
requires left and right value both beNotNull
while_eventsDescriptors
is nullable.Fixes # (issue)
Type of change
How Has This Been Tested?
Existing tests.
Test Configuration:
Checklist: