Add overloads on ContractManagement #2242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shargon
reviewed
Jan 17, 2021
| @@ -121,7 +121,7 @@ internal void Invoke(ApplicationEngine engine) | |||
| throw new InvalidOperationException("It is not allowed to use Neo.Native.Call directly to call native contracts. System.Contract.Call should be used."); | |||
| ExecutionContext context = engine.CurrentContext; | |||
| string operation = context.EvaluationStack.Pop().GetString(); | |||
| ContractMethodMetadata method = methods[operation]; | |||
| ContractMethodMetadata method = methods[(operation, context.EvaluationStack.Count)]; | |||
There was a problem hiding this comment.
It could be possible to have more items before cal the method? 🤔
There was a problem hiding this comment.
InvocationScript it's controlled by the user, and maybe it can choose a different method if he add a new item.
There was a problem hiding this comment.
If he pushes more or less items, the contract should fail.
|
Test passed with NEP17 contract deploy/update. |
shargon
approved these changes
Jan 18, 2021
cloud8little
pushed a commit
to cloud8little/neo
that referenced
this pull request
Jan 24, 2021
ixje
added a commit
to CityOfZion/neo-mamba
that referenced
this pull request
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.