Allow method overloads #2237
Merged
Allow method overloads #2237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shargon
reviewed
Jan 15, 2021
shargon
reviewed
Jan 15, 2021
| @@ -391,14 +391,18 @@ public long CalculateNetworkFee(StoreView snapshot, Transaction tx) | |||
| { | |||
| var contract = NativeContract.ContractManagement.GetContract(snapshot, hash); | |||
| if (contract is null) continue; | |||
| var md = contract.Manifest.Abi.GetMethod("verify", 0); | |||
There was a problem hiding this comment.
Suggested change
| var md = contract.Manifest.Abi.GetMethod("verify", 0); | |
| var md = contract.Manifest.Abi.GetMethod("verify", -1); |
There was a problem hiding this comment.
I think the wallet support 0 parameter only. Because no InvocationScript is provided.
There was a problem hiding this comment.
Just a side note, but we use verify with parameter (a signature) in the Notary contract (#1573). But this can be accounted for when/if implementing support for it.
shargon
reviewed
Jan 15, 2021
shargon
reviewed
Jan 15, 2021
exceptionalexception
previously approved these changes
Jan 16, 2021
shargon
reviewed
Jan 16, 2021
shargon
approved these changes
Jan 16, 2021
cloud8little
pushed a commit
to cloud8little/neo
that referenced
this pull request
Jan 24, 2021
ixje
added a commit
to CityOfZion/neo-mamba
that referenced
this pull request
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.