Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic Call #2167

Merged
merged 10 commits into from
Dec 28, 2020
Merged

Dynamic Call #2167

merged 10 commits into from
Dec 28, 2020

Conversation

erikzhang
Copy link
Member

@erikzhang erikzhang commented Dec 19, 2020 •
edited by shargon
Loading

Close #2173

@erikzhang erikzhang added this to the NEO 3.0 milestone Dec 19, 2020
@erikzhang
Copy link
Member Author

Can someone fix the UTs? 😅

@erikzhang
Copy link
Member Author

Wait for #2168

@shargon
Copy link
Member

shargon commented Dec 20, 2020 •
edited
Loading

I will fix the UT after #2168

@superboyiii superboyiii mentioned this pull request Dec 21, 2020
Closed
36 tasks
@erikzhang erikzhang mentioned this pull request Dec 22, 2020
Closed
@erikzhang
Copy link
Member Author

@shargon Now we can move on.

@erikzhang erikzhang mentioned this pull request Dec 24, 2020
Merged
@Tommo-L
Copy link
Contributor

Tommo-L commented Dec 25, 2020

UT failed

@shargon
Copy link
Member

shargon commented Dec 27, 2020

Give me one day to fix the UT

@shargon
Copy link
Member

shargon commented Dec 27, 2020

@superboyiii could you test it?

@superboyiii
Copy link
Member

@superboyiii could you test it?

Sure

@superboyiii
Copy link
Member

I've tested vote, register, make Txs via send command and invoke nep5 methods like balanceOf, decimals and totalSupply. They all work well.

@erikzhang
Copy link
Member Author

Go?

@superboyiii superboyiii mentioned this pull request Dec 28, 2020
Merged
@erikzhang erikzhang merged commit 91fb44c into master Dec 28, 2020
@erikzhang erikzhang deleted the CI00257 branch December 28, 2020 10:50
@fyrchik fyrchik mentioned this pull request Dec 29, 2020
Closed
ShawnYun pushed a commit to ShawnYun/neo that referenced this pull request Jan 8, 2021
@erikzhang
Dynamic Call (neo-project#2167)
a81ce7b
cloud8little pushed a commit to cloud8little/neo that referenced this pull request Jan 24, 2021
@erikzhang @cloud8little
Dynamic Call (neo-project#2167)
f69ddf2
ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Feb 3, 2021
@ixje
https://github.com/neo-project/neo/pull/2167
7e95061
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vncoelho vncoelho vncoelho approved these changes

@shargon shargon shargon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
NEO 3.0
Development

Successfully merging this pull request may close these issues.

Neo doesn't compile against Neo VM master branch
5 participants
@erikzhang @shargon @Tommo-L @superboyiii @vncoelho