Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make KeyBuilder public so neo-debugger can use it #2099

Merged
merged 5 commits into from
Nov 25, 2020
Merged

Make KeyBuilder public so neo-debugger can use it #2099

merged 5 commits into from
Nov 25, 2020

Conversation

devhawk
Copy link
Contributor

@devhawk devhawk commented Nov 24, 2020

No description provided.

Tommo-L
Tommo-L previously approved these changes Nov 25, 2020
View reviewed changes
shargon
shargon previously approved these changes Nov 25, 2020
View reviewed changes
@erikzhang
Copy link
Member

The KeyBuilder class is used in native contracts only. If it will be used in other places, I think it should be moved to other namespace instead of Neo.SmartContract.Native.

@shargon shargon dismissed stale reviews from Tommo-L and themself via f44ea17 November 25, 2020 10:34
@shargon shargon merged commit 8979c40 into neo-project:master Nov 25, 2020
AnnaShaleva pushed a commit to AnnaShaleva/neo that referenced this pull request Nov 26, 2020
@devhawk @shargon @AnnaShaleva
Make KeyBuilder public so neo-debugger can use it (neo-project#2099)
c81d9ca 
* Make KeyBuilder public so neo-debugger can use it

* Move namespace

* Clean using

Co-authored-by: Shargon <[email protected]>
@devhawk devhawk deleted the patch-6 branch December 9, 2020 17:54
ShawnYun pushed a commit to ShawnYun/neo that referenced this pull request Jan 8, 2021
@devhawk @shargon
Make KeyBuilder public so neo-debugger can use it (neo-project#2099)
609024d 
* Make KeyBuilder public so neo-debugger can use it

* Move namespace

* Clean using

Co-authored-by: Shargon <[email protected]>
cloud8little pushed a commit to cloud8little/neo that referenced this pull request Jan 24, 2021
@devhawk @shargon @cloud8little
Make KeyBuilder public so neo-debugger can use it (neo-project#2099)
48be105 
* Make KeyBuilder public so neo-debugger can use it

* Move namespace

* Clean using

Co-authored-by: Shargon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikzhang erikzhang erikzhang approved these changes

@shargon shargon shargon approved these changes

@Tommo-L Tommo-L Tommo-L left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devhawk @erikzhang @shargon @Tommo-L