Add Fee Ratio #2032

Qiao-Jin · 2020-10-28T03:38:31Z

Close #1875 & another implementation of dynamic "fee ratio" part in #1453.

This PR aims to implement a dynamic fee ratio which can be used to adjust real gas cost of transactions, i.e. when ratio = 2, overall transaction gas cost will be half of original value. This ratio can be adjusted by committee members if needed.

src/neo/SmartContract/Native/PolicyContract.cs

vncoelho · 2020-10-28T11:14:39Z

src/neo/Ledger/Blockchain.cs

@@ -459,7 +460,7 @@ private void Persist(Block block)
                    clonedSnapshot.Transactions.Add(tx.Hash, state);
                    clonedSnapshot.Transactions.Commit();

-                    using (ApplicationEngine engine = ApplicationEngine.Create(TriggerType.Application, tx, clonedSnapshot, tx.SystemFee))
+                    using (ApplicationEngine engine = ApplicationEngine.Create(TriggerType.Application, tx, clonedSnapshot, tx.SystemFee * ratio))


Very good. I like this design.
Thus, ratio 0.5 makes the network more expensive.

vncoelho · 2020-10-28T11:15:38Z

src/neo/Network/P2P/Payloads/Transaction.cs

@@ -294,7 +294,7 @@ public virtual VerifyResult VerifyStateDependent(StoreView snapshot, Transaction
            foreach (TransactionAttribute attribute in Attributes)
                if (!attribute.Verify(snapshot, this))
                    return VerifyResult.Invalid;
-            long net_fee = NetworkFee - Size * NativeContract.Policy.GetFeePerByte(snapshot);
+            long net_fee = NetworkFee * NativeContract.Policy.GetFeeRatio(snapshot) - Size * NativeContract.Policy.GetFeePerByte(snapshot);


It is the same, but maybe:
(NetworkFee * NativeContract.Policy.GetFeeRatio(snapshot)) - (Size * NativeContract.Policy.GetFeePerByte(snapshot)), to make it clear.

Have fixed, please have a check

Qiao-Jin · 2020-10-29T04:01:00Z

In the latest commit I changed the definition of FeeRatio. After changing the 'real' price of each opcode/interop will be as follows:

original value * FeeRatio / 100

Or in other word, FeeRatio means how many percent of original price the current price is.

Initial FeeRatio will be 100. FeeRatio will range from 1 to 10000.

erikzhang · 2020-10-29T11:28:56Z

neo/src/neo/SmartContract/ApplicationEngine.OpCodePrices.cs

Line 39 in 7a8bb73

[OpCode.NOP] = 30,

I think the easiest way is to set the price of NOP to 1, and then the initial ratio is 30.

Qiao-Jin · 2020-10-30T02:41:24Z

neo/src/neo/SmartContract/ApplicationEngine.OpCodePrices.cs

Line 39 in 7a8bb73

[OpCode.NOP] = 30,

I think the easiest way is to set the price of NOP to 1, and then the initial ratio is 30.

This PR provides a method to set overall fee dynamically. If we don't set such an ratio and want to change tx fee later, we would need a hard folk.

Qiao-Jin · 2020-11-02T07:09:48Z

Can we merge this one?

erikzhang · 2020-11-02T09:43:22Z

I think the easiest way is to set the price of NOP to 1, and then the initial ratio is 30.

We should implement this first.

Qiao-Jin · 2020-11-02T10:03:01Z

I think the easiest way is to set the price of NOP to 1, and then the initial ratio is 30.

We should implement this first.

Do we need a hard-coded ratio or a dynamic one like described in this PR?

erikzhang · 2020-11-02T10:06:37Z

Do we need a hard-coded ratio or a dynamic one like described in this PR?

We need a dynamic one with the initial value 30.

Qiao-Jin · 2020-11-03T06:53:40Z

We need a dynamic one with the initial value 30.

Done

erikzhang · 2020-11-03T12:31:02Z

This ratio should not affect the storage price. And many native contract methods are based on the storage size.

Qiao-Jin · 2020-11-04T08:29:05Z

This ratio should not affect the storage price. And many native contract methods are based on the storage size.

Have done

shargon

In which case we want to use withoutRatio for witnesses ?

Qiao-Jin · 2020-11-05T02:40:09Z

In which case we want to use withoutRatio for witnesses ?

For opcodes & interops which should not be influenced by fee ratio i.e. StoragePrice

shargon · 2020-11-05T15:11:10Z

This ratio should not affect the storage price

If we want to pay 1 USD per byte (for example), we will need to affect the storage price, isn't it?

roman-khimov · 2020-11-05T16:16:50Z

If we want to pay 1 USD per byte (for example), we will need to affect the storage price, isn't it?

I think any storage-related prices can be derived from FeePerByte (StoragePrice = 100 * FeePerByte, etc). And then syscalls can make any proportions using FeePerByte (for storage) and NOP fee (for execution). So they could specify an amount of work they're doing in bytes/nops (minimal units of work) and then the ApplicationEngine would translate it to GAS according to current GAS value for these basic units of work.

Qiao-Jin · 2020-11-06T02:52:50Z

I think any storage-related prices can be derived from FeePerByte (StoragePrice = 100 * FeePerByte, etc)

FeePerByte is for network transmission and StoragePrice is for storage, they are for different usage & don't have direct relationship, so I don't think it's good to keep them synchronized.

Qiao-Jin · 2020-11-11T04:10:52Z

I rewrote the fee logic so that fee ratio is applied to each opcode & interops. Scenarios for func Transaction.VerifyIndependent where input snapshot is null are also considered. Original logic of func VerifyWitnesses is restored to make corresponding logic simpler.

erikzhang · 2020-11-11T05:50:11Z

src/neo/SmartContract/ApplicationEngine.cs

@@ -67,10 +69,12 @@ protected ApplicationEngine(TriggerType trigger, IVerifiable container, StoreVie
            this.ScriptContainer = container;
            this.Snapshot = snapshot;
            this.gas_amount = gas;
+            this.feeRatio = snapshot is null ? 1 : NativeContract.Policy.GetFeeRatio(Snapshot);


The verifications always use the ratio 1?

This serves scenarios such as Transaction.VerifyIndependent where input snapshot is null. In such cases we should use minimum fee ratio. This is because if fee ratio is really set to 1, using other values might drop transactions which are actually valid. And the "real" expense used by verifying witness will be checked afterwards in Transaction.VerifyDependent so that no invalid transaction will get on chain.

But 1 will cause attacks.

But 1 will cause attacks.

In PR #2054, we will check whether a witness's VerificationScript is StandardContract, so that attack can be blocked.

shargon · 2020-11-11T12:39:34Z

I think that we should decide if we want to work on this version or #2045
Can we use #1875 for this discussion?

Qiao-Jin · 2020-11-12T03:54:23Z

I think that we should decide if we want to work on this version or #2045

I personally think this PR works better because:

(1) Interop services are also considered. As VM expense = fee of opcodes + fee of interops, interops should also be considered naturally.

(2) In this PR hard-coded limitations are also considered such as TestModeFee, OracleRequestPrice, etc. These limitations should also be considered in case of fee ratio changing.

Can we use #1875 for this discussion?

Sure of course.

Jin Qiao and others added 2 commits October 28, 2020 11:36

Add Fee Ratio

2a4f3cb

optimize

3630511

shargon reviewed Oct 28, 2020

View reviewed changes

src/neo/SmartContract/Native/PolicyContract.cs Show resolved Hide resolved

vncoelho reviewed Oct 28, 2020

View reviewed changes

diskooooo mentioned this pull request Oct 28, 2020

Redefine opcode prices and make them adjustable #1875

Closed

Qiao-Jin and others added 2 commits October 29, 2020 10:37

Merge branch 'master' into add_fee_ratio

0e8f866

Set ratio range

fe9d3e1

Merge branch 'master' into add_fee_ratio

472d113

Merge branch 'master' into add_fee_ratio

153b295

superboyiii mentioned this pull request Nov 2, 2020

Preview4 Checklist #1936

Closed

44 tasks

Qiao-Jin and others added 2 commits November 3, 2020 14:46

Merge branch 'master' into add_fee_ratio

fbd3ebc

Redefine all prices

7970200

Merge branch 'master' into add_fee_ratio

f7a8bc6

Qiao-Jin and others added 3 commits November 4, 2020 10:52

Merge branch 'master' into add_fee_ratio

610d768

Optimize

9aace9f

format

1abfc6f

shargon reviewed Nov 4, 2020

View reviewed changes

Merge branch 'master' into add_fee_ratio

f4e9330

Qiao Jin added 3 commits November 5, 2020 11:13

Fix typo

9c0ad3a

fee adjust

7e67f44

fee adjust

cb59e8f

Qiao-Jin and others added 3 commits November 6, 2020 10:58

Merge branch 'master' into add_fee_ratio

aa29222

Merge branch 'master' into add_fee_ratio

700d782

Rewrite logic

ee56bf6

fix ut

dab166b

erikzhang reviewed Nov 11, 2020

View reviewed changes

Qiao Jin added 7 commits November 11, 2020 14:28

fix OracleRequestPrice

d3a36e6

Revert ut

de87b08

fix GetBalance

379e7ae

Optimize

c23472c

format

a082979

fix MaxVerificationGas

0df7915

fix MaxVerificationGas

e49b825

Qiao-Jin added 2 commits November 12, 2020 14:30

Merge branch 'master' into add_fee_ratio

f11a75e

Merge branch 'master' into add_fee_ratio

e778f02

Qiao-Jin closed this Nov 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Fee Ratio #2032

Add Fee Ratio #2032

Qiao-Jin commented Oct 28, 2020 •

edited

Loading

vncoelho Oct 28, 2020

vncoelho Oct 28, 2020 •

edited

Loading

Qiao-Jin Oct 29, 2020

Qiao-Jin commented Oct 29, 2020

erikzhang commented Oct 29, 2020

Qiao-Jin commented Oct 30, 2020 •

edited

Loading

Qiao-Jin commented Nov 2, 2020

erikzhang commented Nov 2, 2020

Qiao-Jin commented Nov 2, 2020 •

edited

Loading

erikzhang commented Nov 2, 2020

Qiao-Jin commented Nov 3, 2020

erikzhang commented Nov 3, 2020

Qiao-Jin commented Nov 4, 2020

shargon left a comment

Qiao-Jin commented Nov 5, 2020

shargon commented Nov 5, 2020

roman-khimov commented Nov 5, 2020

Qiao-Jin commented Nov 6, 2020

Qiao-Jin commented Nov 11, 2020

erikzhang Nov 11, 2020

Qiao-Jin Nov 11, 2020 •

edited

Loading

erikzhang Nov 11, 2020

Qiao-Jin Nov 11, 2020 •

edited

Loading

shargon commented Nov 11, 2020 •

edited

Loading

Qiao-Jin commented Nov 12, 2020 •

edited

Loading

Add Fee Ratio #2032

Add Fee Ratio #2032

Conversation

Qiao-Jin commented Oct 28, 2020 • edited Loading

vncoelho Oct 28, 2020

Choose a reason for hiding this comment

vncoelho Oct 28, 2020 • edited Loading

Choose a reason for hiding this comment

Qiao-Jin Oct 29, 2020

Choose a reason for hiding this comment

Qiao-Jin commented Oct 29, 2020

erikzhang commented Oct 29, 2020

Qiao-Jin commented Oct 30, 2020 • edited Loading

Qiao-Jin commented Nov 2, 2020

erikzhang commented Nov 2, 2020

Qiao-Jin commented Nov 2, 2020 • edited Loading

erikzhang commented Nov 2, 2020

Qiao-Jin commented Nov 3, 2020

erikzhang commented Nov 3, 2020

Qiao-Jin commented Nov 4, 2020

shargon left a comment

Choose a reason for hiding this comment

Qiao-Jin commented Nov 5, 2020

shargon commented Nov 5, 2020

roman-khimov commented Nov 5, 2020

Qiao-Jin commented Nov 6, 2020

Qiao-Jin commented Nov 11, 2020

erikzhang Nov 11, 2020

Choose a reason for hiding this comment

Qiao-Jin Nov 11, 2020 • edited Loading

Choose a reason for hiding this comment

erikzhang Nov 11, 2020

Choose a reason for hiding this comment

Qiao-Jin Nov 11, 2020 • edited Loading

Choose a reason for hiding this comment

shargon commented Nov 11, 2020 • edited Loading

Qiao-Jin commented Nov 12, 2020 • edited Loading

Qiao-Jin commented Oct 28, 2020 •

edited

Loading

vncoelho Oct 28, 2020 •

edited

Loading

Qiao-Jin commented Oct 30, 2020 •

edited

Loading

Qiao-Jin commented Nov 2, 2020 •

edited

Loading

Qiao-Jin Nov 11, 2020 •

edited

Loading

Qiao-Jin Nov 11, 2020 •

edited

Loading

shargon commented Nov 11, 2020 •

edited

Loading

Qiao-Jin commented Nov 12, 2020 •

edited

Loading